chrome/renderer/safe_browsing/malware_dom_details.h - Issue 663333002: Standardize usage of virtual/override/final in chrome/renderer/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/safe_browsing/malware_dom_details.h

Issue 663333002: Standardize usage of virtual/override/final in chrome/renderer/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/printing/print_web_view_helper_browsertest.cc ('k') | chrome/renderer/safe_browsing/phishing_classifier_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/safe_browsing/malware_dom_details.h

diff --git a/chrome/renderer/safe_browsing/malware_dom_details.h b/chrome/renderer/safe_browsing/malware_dom_details.h

index 9bac6958872da484d88b3e5d3f62c5dceaafb46e..f65007fbd2ea7283c3072284dd4a684b8d4ca292 100644

--- a/chrome/renderer/safe_browsing/malware_dom_details.h

+++ b/chrome/renderer/safe_browsing/malware_dom_details.h

@@ -26,7 +26,7 @@ class MalwareDOMDetails : public content::RenderViewObserver {

static uint32 kMaxNodes;

static MalwareDOMDetails* Create(content::RenderView* render_view);

- virtual ~MalwareDOMDetails();

+ ~MalwareDOMDetails() override;

// Begins extracting resource urls for the page currently loaded in

// this object's RenderView.

@@ -41,7 +41,7 @@ class MalwareDOMDetails : public content::RenderViewObserver {

explicit MalwareDOMDetails(content::RenderView* render_view);

// RenderViewObserver implementation.

- virtual bool OnMessageReceived(const IPC::Message& message) override;

+ bool OnMessageReceived(const IPC::Message& message) override;

void OnGetMalwareDOMDetails();