Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4369)

Unified Diff: chrome/renderer/security_filter_peer.h

Issue 663333002: Standardize usage of virtual/override/final in chrome/renderer/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/security_filter_peer.h
diff --git a/chrome/renderer/security_filter_peer.h b/chrome/renderer/security_filter_peer.h
index e99f95142835c43e2f152ac74f5c50653292bf4a..0ce60922dd95da4175a84d2502ab1fe224d70671 100644
--- a/chrome/renderer/security_filter_peer.h
+++ b/chrome/renderer/security_filter_peer.h
@@ -18,7 +18,7 @@
// OnReceiveComplete call.
class SecurityFilterPeer : public content::RequestPeer {
public:
- virtual ~SecurityFilterPeer();
+ ~SecurityFilterPeer() override;
static SecurityFilterPeer* CreateSecurityFilterPeerForDeniedRequest(
content::ResourceType resource_type,
@@ -30,22 +30,20 @@ class SecurityFilterPeer : public content::RequestPeer {
int os_error);
// content::RequestPeer methods.
- virtual void OnUploadProgress(uint64 position, uint64 size) override;
- virtual bool OnReceivedRedirect(
- const net::RedirectInfo& redirect_info,
- const content::ResourceResponseInfo& info) override;
- virtual void OnReceivedResponse(
- const content::ResourceResponseInfo& info) override;
- virtual void OnDownloadedData(int len, int encoded_data_length) override {}
- virtual void OnReceivedData(const char* data,
- int data_length,
- int encoded_data_length) override;
- virtual void OnCompletedRequest(int error_code,
- bool was_ignored_by_handler,
- bool stale_copy_in_cache,
- const std::string& security_info,
- const base::TimeTicks& completion_time,
- int64 total_transfer_size) override;
+ void OnUploadProgress(uint64 position, uint64 size) override;
+ bool OnReceivedRedirect(const net::RedirectInfo& redirect_info,
+ const content::ResourceResponseInfo& info) override;
+ void OnReceivedResponse(const content::ResourceResponseInfo& info) override;
+ void OnDownloadedData(int len, int encoded_data_length) override {}
+ void OnReceivedData(const char* data,
+ int data_length,
+ int encoded_data_length) override;
+ void OnCompletedRequest(int error_code,
+ bool was_ignored_by_handler,
+ bool stale_copy_in_cache,
+ const std::string& security_info,
+ const base::TimeTicks& completion_time,
+ int64 total_transfer_size) override;
protected:
explicit SecurityFilterPeer(content::RequestPeer* peer);
@@ -61,21 +59,19 @@ class SecurityFilterPeer : public content::RequestPeer {
class BufferedPeer : public SecurityFilterPeer {
public:
BufferedPeer(content::RequestPeer* peer, const std::string& mime_type);
- virtual ~BufferedPeer();
+ ~BufferedPeer() override;
// content::RequestPeer Implementation.
- virtual void OnReceivedResponse(
- const content::ResourceResponseInfo& info) override;
- virtual void OnReceivedData(const char* data,
- int data_length,
- int encoded_data_length) override;
- virtual void OnCompletedRequest(
- int error_code,
- bool was_ignored_by_handler,
- bool stale_copy_in_cache,
- const std::string& security_info,
- const base::TimeTicks& completion_time,
- int64 total_transfer_size) override;
+ void OnReceivedResponse(const content::ResourceResponseInfo& info) override;
+ void OnReceivedData(const char* data,
+ int data_length,
+ int encoded_data_length) override;
+ void OnCompletedRequest(int error_code,
+ bool was_ignored_by_handler,
+ bool stale_copy_in_cache,
+ const std::string& security_info,
+ const base::TimeTicks& completion_time,
+ int64 total_transfer_size) override;
protected:
// Invoked when the entire request has been processed before the data is sent
@@ -104,21 +100,19 @@ class ReplaceContentPeer : public SecurityFilterPeer {
ReplaceContentPeer(content::RequestPeer* peer,
const std::string& mime_type,
const std::string& data);
- virtual ~ReplaceContentPeer();
+ ~ReplaceContentPeer() override;
// content::RequestPeer Implementation.
- virtual void OnReceivedResponse(
- const content::ResourceResponseInfo& info) override;
- virtual void OnReceivedData(const char* data,
- int data_length,
- int encoded_data_length) override;
- virtual void OnCompletedRequest(
- int error_code,
- bool was_ignored_by_handler,
- bool stale_copy_in_cache,
- const std::string& security_info,
- const base::TimeTicks& completion_time,
- int64 total_transfer_size) override;
+ void OnReceivedResponse(const content::ResourceResponseInfo& info) override;
+ void OnReceivedData(const char* data,
+ int data_length,
+ int encoded_data_length) override;
+ void OnCompletedRequest(int error_code,
+ bool was_ignored_by_handler,
+ bool stale_copy_in_cache,
+ const std::string& security_info,
+ const base::TimeTicks& completion_time,
+ int64 total_transfer_size) override;
private:
content::ResourceResponseInfo response_info_;
« no previous file with comments | « chrome/renderer/searchbox/searchbox_extension.cc ('k') | chrome/renderer/spellchecker/cocoa_spelling_engine_mac.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698