Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Side by Side Diff: chrome/renderer/chrome_content_renderer_client.cc

Issue 663333002: Standardize usage of virtual/override/final in chrome/renderer/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/renderer/chrome_content_renderer_client.h" 5 #include "chrome/renderer/chrome_content_renderer_client.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/debug/crash_logging.h" 8 #include "base/debug/crash_logging.h"
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "base/metrics/field_trial.h" 10 #include "base/metrics/field_trial.h"
(...skipping 196 matching lines...) Expand 10 before | Expand all | Expand 10 after
207 207
208 existing_names->swap(names); 208 existing_names->swap(names);
209 existing_values->swap(values); 209 existing_values->swap(values);
210 } 210 }
211 211
212 #if defined(ENABLE_SPELLCHECK) 212 #if defined(ENABLE_SPELLCHECK)
213 class SpellCheckReplacer : public content::RenderViewVisitor { 213 class SpellCheckReplacer : public content::RenderViewVisitor {
214 public: 214 public:
215 explicit SpellCheckReplacer(SpellCheck* spellcheck) 215 explicit SpellCheckReplacer(SpellCheck* spellcheck)
216 : spellcheck_(spellcheck) {} 216 : spellcheck_(spellcheck) {}
217 virtual bool Visit(content::RenderView* render_view) override; 217 bool Visit(content::RenderView* render_view) override;
218 218
219 private: 219 private:
220 SpellCheck* spellcheck_; // New shared spellcheck for all views. Weak Ptr. 220 SpellCheck* spellcheck_; // New shared spellcheck for all views. Weak Ptr.
221 DISALLOW_COPY_AND_ASSIGN(SpellCheckReplacer); 221 DISALLOW_COPY_AND_ASSIGN(SpellCheckReplacer);
222 }; 222 };
223 223
224 bool SpellCheckReplacer::Visit(content::RenderView* render_view) { 224 bool SpellCheckReplacer::Visit(content::RenderView* render_view) {
225 SpellCheckProvider* provider = SpellCheckProvider::Get(render_view); 225 SpellCheckProvider* provider = SpellCheckProvider::Get(render_view);
226 DCHECK(provider); 226 DCHECK(provider);
227 provider->set_spellcheck(spellcheck_); 227 provider->set_spellcheck(spellcheck_);
(...skipping 1343 matching lines...) Expand 10 before | Expand all | Expand 10 after
1571 content::BrowserPluginDelegate* 1571 content::BrowserPluginDelegate*
1572 ChromeContentRendererClient::CreateBrowserPluginDelegate( 1572 ChromeContentRendererClient::CreateBrowserPluginDelegate(
1573 content::RenderFrame* render_frame, 1573 content::RenderFrame* render_frame,
1574 const std::string& mime_type) { 1574 const std::string& mime_type) {
1575 #if defined(ENABLE_EXTENSIONS) 1575 #if defined(ENABLE_EXTENSIONS)
1576 return new extensions::GuestViewContainer(render_frame, mime_type); 1576 return new extensions::GuestViewContainer(render_frame, mime_type);
1577 #else 1577 #else
1578 return NULL; 1578 return NULL;
1579 #endif 1579 #endif
1580 } 1580 }
OLDNEW
« no previous file with comments | « chrome/renderer/chrome_content_renderer_client.h ('k') | chrome/renderer/chrome_mock_render_thread.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698