chrome/renderer/benchmarking_extension.cc - Issue 663333002: Standardize usage of virtual/override/final in chrome/renderer/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/benchmarking_extension.cc

Issue 663333002: Standardize usage of virtual/override/final in chrome/renderer/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/autofill/page_click_tracker_browsertest.cc ('k') | chrome/renderer/chrome_content_renderer_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/benchmarking_extension.cc

diff --git a/chrome/renderer/benchmarking_extension.cc b/chrome/renderer/benchmarking_extension.cc

index d5ddd27cf685bf695e86515062bce3701e5f0f0f..d8372d8f2fe9370f5a61d953809f823b39958831 100644

--- a/chrome/renderer/benchmarking_extension.cc

+++ b/chrome/renderer/benchmarking_extension.cc

@@ -59,7 +59,7 @@ class BenchmarkingWrapper : public v8::Extension {

"}"

) {}

- virtual v8::Handle<v8::FunctionTemplate> GetNativeFunctionTemplate(

+ v8::Handle<v8::FunctionTemplate> GetNativeFunctionTemplate(

v8::Isolate* isolate,

v8::Handle<v8::String> name) override {

if (name->Equals(v8::String::NewFromUtf8(isolate, "GetCounter"))) {

« no previous file with comments | « chrome/renderer/autofill/page_click_tracker_browsertest.cc ('k') | chrome/renderer/chrome_content_renderer_client.h » ('j') | no next file with comments »