Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 655713003: Standardize usage of virtual/override/final in media/ (Closed)

Created:
6 years, 2 months ago by dcheng
Modified:
6 years, 2 months ago
Reviewers:
ddorwin
CC:
Aaron Boodman, abarth-chromium, avayvod+watch_chromium.org, ben+mojo_chromium.org, cbentzel+watch_chromium.org, chromium-reviews, darin (slow to review), eme-reviews_chromium.org, feature-media-reviews_chromium.org, hclam+watch_chromium.org, hguihot+watch_chromium.org, hubbe+watch_chromium.org, imcheng+watch_chromium.org, jasonroberts+watch_google.com, jshin+watch_chromium.org, mcasas+watch_chromium.org, mikhal+watch_chromium.org, miu+watch_chromium.org, posciak+watch_chromium.org, pwestin+watch_google.com, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, wjia+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Standardize usage of virtual/override/final in media/ This patch was automatically generated by applying clang fixit hints generated by the plugin to the source tree. BUG=417463 TBR=ddorwin@chromium.org Committed: https://crrev.com/c24565478f64d1aa4d07e83c69d00bad11fa2665 Cr-Commit-Position: refs/heads/master@{#300471}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1171 lines, -1250 lines) Patch
M media/audio/audio_device_thread.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/audio/audio_input_controller.h View 2 chunks +6 lines, -6 lines 0 comments Download
M media/audio/audio_input_device.h View 2 chunks +16 lines, -17 lines 0 comments Download
M media/audio/audio_input_device.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M media/audio/audio_input_unittest.cc View 1 chunk +5 lines, -7 lines 0 comments Download
M media/audio/audio_manager_base.h View 2 chunks +19 lines, -24 lines 0 comments Download
M media/audio/audio_output_controller.h View 2 chunks +7 lines, -8 lines 0 comments Download
M media/audio/audio_output_device.h View 2 chunks +14 lines, -14 lines 0 comments Download
M media/audio/audio_output_device.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M media/audio/audio_output_dispatcher_impl.h View 1 chunk +8 lines, -9 lines 0 comments Download
M media/audio/audio_output_proxy.h View 2 chunks +7 lines, -7 lines 0 comments Download
M media/audio/audio_output_proxy_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/audio/audio_output_resampler.h View 1 chunk +8 lines, -9 lines 0 comments Download
M media/audio/audio_output_resampler.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M media/audio/clockless_audio_sink.h View 1 chunk +8 lines, -8 lines 0 comments Download
M media/audio/clockless_audio_sink.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/fake_audio_input_stream.h View 2 chunks +11 lines, -11 lines 0 comments Download
M media/audio/fake_audio_log_factory.h View 1 chunk +2 lines, -3 lines 0 comments Download
M media/audio/fake_audio_log_factory.cc View 1 chunk +9 lines, -9 lines 0 comments Download
M media/audio/fake_audio_manager.h View 1 chunk +11 lines, -11 lines 0 comments Download
M media/audio/fake_audio_output_stream.h View 1 chunk +7 lines, -7 lines 0 comments Download
M media/audio/mac/audio_auhal_mac.h View 1 chunk +7 lines, -7 lines 0 comments Download
M media/audio/mac/audio_input_mac.h View 1 chunk +11 lines, -11 lines 0 comments Download
M media/audio/mac/audio_low_latency_input_mac.h View 1 chunk +9 lines, -9 lines 0 comments Download
M media/audio/mac/audio_low_latency_input_mac_unittest.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M media/audio/mac/audio_manager_mac.h View 2 chunks +19 lines, -19 lines 0 comments Download
M media/audio/mac/audio_manager_mac.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M media/audio/mock_audio_manager.h View 1 chunk +20 lines, -24 lines 0 comments Download
M media/audio/null_audio_sink.h View 2 chunks +8 lines, -8 lines 0 comments Download
M media/audio/scoped_task_runner_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/simple_sources.h View 2 chunks +3 lines, -4 lines 0 comments Download
M media/audio/sounds/audio_stream_handler.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M media/audio/sounds/sounds_manager.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M media/audio/sounds/test_data.h View 1 chunk +3 lines, -3 lines 0 comments Download
M media/audio/test_audio_input_controller_factory.h View 2 chunks +5 lines, -5 lines 0 comments Download
M media/audio/virtual_audio_input_stream.h View 1 chunk +11 lines, -11 lines 0 comments Download
M media/audio/virtual_audio_input_stream.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M media/audio/virtual_audio_input_stream_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M media/audio/virtual_audio_output_stream.h View 1 chunk +9 lines, -9 lines 0 comments Download
M media/base/audio_buffer_converter.h View 2 chunks +3 lines, -3 lines 0 comments Download
M media/base/audio_bus.h View 1 chunk +1 line, -1 line 0 comments Download
M media/base/audio_converter_perftest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M media/base/audio_renderer_mixer.h View 2 chunks +3 lines, -4 lines 0 comments Download
M media/base/audio_renderer_mixer_input.h View 2 chunks +10 lines, -10 lines 0 comments Download
M media/base/bit_reader.h View 2 chunks +2 lines, -2 lines 0 comments Download
M media/base/demuxer.h View 1 chunk +1 line, -1 line 0 comments Download
M media/base/demuxer_perftest.cc View 1 chunk +8 lines, -8 lines 0 comments Download
M media/base/fake_audio_renderer_sink.h View 2 chunks +8 lines, -8 lines 0 comments Download
M media/base/pipeline.h View 2 chunks +8 lines, -8 lines 0 comments Download
M media/base/run_all_perftests.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M media/base/run_all_unittests.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M media/base/stream_parser_buffer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M media/base/user_input_monitor_mac.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M media/base/video_frame_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M media/base/wall_clock_time_source.h View 1 chunk +7 lines, -7 lines 0 comments Download
M media/blink/buffered_data_source.h View 2 chunks +10 lines, -8 lines 0 comments Download
M media/blink/buffered_data_source_host_impl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M media/blink/new_session_cdm_result_promise.h View 1 chunk +5 lines, -5 lines 0 comments Download
M media/blink/null_encrypted_media_player_support.h View 2 chunks +10 lines, -12 lines 0 comments Download
M media/blink/texttrack_impl.h View 1 chunk +6 lines, -6 lines 0 comments Download
M media/blink/video_frame_compositor.h View 1 chunk +4 lines, -5 lines 0 comments Download
M media/blink/webaudiosourceprovider_impl.h View 1 chunk +7 lines, -7 lines 0 comments Download
M media/blink/webmediaplayer_impl.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M media/cast/cast_sender_impl.h View 1 chunk +6 lines, -7 lines 0 comments Download
M media/cast/cast_sender_impl.cc View 4 chunks +6 lines, -7 lines 0 comments Download
M media/cast/logging/encoding_event_subscriber.h View 1 chunk +3 lines, -3 lines 0 comments Download
M media/cast/logging/receiver_time_offset_estimator.h View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/logging/receiver_time_offset_estimator_impl.h View 1 chunk +5 lines, -5 lines 0 comments Download
M media/cast/logging/simple_event_subscriber.h View 1 chunk +3 lines, -3 lines 0 comments Download
M media/cast/logging/stats_event_subscriber.h View 1 chunk +3 lines, -3 lines 0 comments Download
M media/cast/net/cast_transport_sender_impl.h View 1 chunk +15 lines, -17 lines 0 comments Download
M media/cast/net/cast_transport_sender_impl_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M media/cast/net/pacing/paced_sender.h View 2 chunks +6 lines, -6 lines 0 comments Download
M media/cast/net/pacing/paced_sender_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M media/cast/net/rtcp/receiver_rtcp_event_subscriber.h View 1 chunk +3 lines, -3 lines 0 comments Download
M media/cast/net/rtcp/rtcp_unittest.cc View 2 chunks +10 lines, -13 lines 0 comments Download
M media/cast/net/rtp/cast_message_builder_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/net/rtp/receiver_stats.h View 1 chunk +5 lines, -5 lines 0 comments Download
M media/cast/net/rtp/rtp_packetizer_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M media/cast/net/udp_transport.h View 2 chunks +3 lines, -4 lines 0 comments Download
M media/cast/receiver/audio_decoder.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M media/cast/receiver/cast_receiver_impl.h View 1 chunk +6 lines, -6 lines 0 comments Download
M media/cast/receiver/frame_receiver.h View 2 chunks +2 lines, -2 lines 0 comments Download
M media/cast/receiver/video_decoder.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M media/cast/sender/audio_encoder.cc View 4 chunks +12 lines, -12 lines 0 comments Download
M media/cast/sender/audio_sender.h View 2 chunks +4 lines, -4 lines 0 comments Download
M media/cast/sender/audio_sender_unittest.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M media/cast/sender/congestion_control.cc View 2 chunks +18 lines, -22 lines 0 comments Download
M media/cast/sender/external_video_encoder.h View 1 chunk +5 lines, -5 lines 0 comments Download
M media/cast/sender/external_video_encoder.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M media/cast/sender/fake_software_video_encoder.h View 1 chunk +8 lines, -8 lines 0 comments Download
M media/cast/sender/video_encoder_impl.h View 1 chunk +5 lines, -5 lines 0 comments Download
M media/cast/sender/video_sender.h View 2 chunks +4 lines, -4 lines 0 comments Download
M media/cast/sender/video_sender_unittest.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M media/cast/sender/vp8_encoder.h View 1 chunk +8 lines, -8 lines 0 comments Download
M media/cast/test/cast_benchmarks.cc View 2 chunks +14 lines, -20 lines 0 comments Download
M media/cast/test/end2end_unittest.cc View 3 chunks +4 lines, -7 lines 0 comments Download
M media/cast/test/fake_receiver_time_offset_estimator.h View 1 chunk +5 lines, -5 lines 0 comments Download
M media/cast/test/fake_single_thread_task_runner.h View 1 chunk +8 lines, -9 lines 0 comments Download
M media/cast/test/fake_video_encode_accelerator.h View 1 chunk +14 lines, -14 lines 0 comments Download
M media/cast/test/loopback_transport.h View 1 chunk +3 lines, -4 lines 0 comments Download
M media/cast/test/loopback_transport.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/cast/test/receiver.cc View 6 chunks +11 lines, -12 lines 0 comments Download
M media/cast/test/skewed_single_thread_task_runner.h View 1 chunk +8 lines, -9 lines 0 comments Download
M media/cast/test/skewed_tick_clock.h View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/test/utility/standalone_cast_environment.h View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/test/utility/udp_proxy.cc View 13 chunks +17 lines, -23 lines 0 comments Download
M media/cast/test/utility/udp_proxy_main.cc View 1 chunk +1 line, -2 lines 0 comments Download
M media/cdm/aes_decryptor.h View 1 chunk +37 lines, -40 lines 0 comments Download
M media/cdm/player_tracker_impl.h View 1 chunk +4 lines, -4 lines 0 comments Download
M media/filters/audio_renderer_impl.h View 2 chunks +19 lines, -20 lines 0 comments Download
M media/filters/blocking_url_protocol.h View 1 chunk +5 lines, -5 lines 0 comments Download
M media/filters/chunk_demuxer.h View 3 chunks +17 lines, -17 lines 0 comments Download
M media/filters/clockless_video_frame_scheduler.h View 1 chunk +5 lines, -5 lines 0 comments Download
M media/filters/decrypting_audio_decoder.h View 1 chunk +8 lines, -8 lines 0 comments Download
M media/filters/decrypting_demuxer_stream.h View 2 chunks +8 lines, -8 lines 0 comments Download
M media/filters/decrypting_video_decoder.h View 1 chunk +9 lines, -9 lines 0 comments Download
M media/filters/fake_demuxer_stream.h View 1 chunk +7 lines, -7 lines 0 comments Download
M media/filters/fake_video_decoder.h View 1 chunk +10 lines, -10 lines 0 comments Download
M media/filters/ffmpeg_audio_decoder.h View 1 chunk +8 lines, -8 lines 0 comments Download
M media/filters/ffmpeg_demuxer.h View 3 chunks +18 lines, -18 lines 0 comments Download
M media/filters/ffmpeg_video_decoder.h View 1 chunk +9 lines, -9 lines 0 comments Download
M media/filters/file_data_source.h View 1 chunk +9 lines, -7 lines 0 comments Download
M media/filters/gpu_video_decoder.h View 1 chunk +21 lines, -21 lines 0 comments Download
M media/filters/in_memory_url_protocol.h View 1 chunk +5 lines, -5 lines 0 comments Download
M media/filters/opus_audio_decoder.h View 1 chunk +8 lines, -8 lines 0 comments Download
M media/filters/pipeline_integration_test.cc View 3 chunks +22 lines, -23 lines 0 comments Download
M media/filters/pipeline_integration_test_base.h View 1 chunk +3 lines, -2 lines 0 comments Download
M media/filters/renderer_impl.h View 1 chunk +15 lines, -15 lines 0 comments Download
M media/filters/skcanvas_video_renderer.cc View 3 chunks +11 lines, -11 lines 0 comments Download
M media/filters/test_video_frame_scheduler.h View 1 chunk +5 lines, -5 lines 0 comments Download
M media/filters/video_frame_scheduler_impl.h View 1 chunk +5 lines, -5 lines 0 comments Download
M media/filters/video_frame_scheduler_proxy.h View 1 chunk +5 lines, -5 lines 0 comments Download
M media/filters/video_renderer_impl.h View 1 chunk +12 lines, -12 lines 0 comments Download
M media/filters/vpx_video_decoder.h View 1 chunk +9 lines, -9 lines 0 comments Download
M media/formats/mpeg/adts_stream_parser.h View 1 chunk +8 lines, -8 lines 0 comments Download
M media/formats/mpeg/mpeg1_audio_stream_parser.h View 1 chunk +8 lines, -8 lines 0 comments Download
M media/formats/mpeg/mpeg_audio_stream_parser_base.h View 1 chunk +11 lines, -11 lines 0 comments Download
M media/formats/webm/webm_audio_client.h View 2 chunks +3 lines, -3 lines 0 comments Download
M media/formats/webm/webm_cluster_parser.h View 2 chunks +5 lines, -5 lines 0 comments Download
M media/formats/webm/webm_content_encodings_client.h View 1 chunk +5 lines, -5 lines 0 comments Download
M media/formats/webm/webm_info_parser.h View 2 chunks +7 lines, -7 lines 0 comments Download
M media/formats/webm/webm_stream_parser.h View 1 chunk +11 lines, -10 lines 0 comments Download
M media/formats/webm/webm_tracks_parser.h View 2 chunks +7 lines, -7 lines 0 comments Download
M media/formats/webm/webm_video_client.h View 2 chunks +4 lines, -4 lines 0 comments Download
M media/midi/midi_manager_mac.h View 1 chunk +6 lines, -6 lines 0 comments Download
M media/midi/midi_manager_unittest.cc View 2 chunks +13 lines, -11 lines 0 comments Download
M media/midi/midi_manager_usb.h View 1 chunk +15 lines, -15 lines 0 comments Download
M media/midi/midi_manager_usb_unittest.cc View 5 chunks +14 lines, -15 lines 0 comments Download
M media/midi/usb_midi_input_stream_unittest.cc View 2 chunks +8 lines, -11 lines 0 comments Download
M media/midi/usb_midi_output_stream_unittest.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M media/mojo/services/mojo_demuxer_stream_adapter.h View 1 chunk +10 lines, -11 lines 0 comments Download
M media/mojo/services/mojo_demuxer_stream_impl.h View 1 chunk +4 lines, -4 lines 0 comments Download
M media/mojo/services/mojo_renderer_impl.h View 1 chunk +19 lines, -20 lines 0 comments Download
M media/mojo/services/mojo_renderer_service.h View 1 chunk +7 lines, -7 lines 0 comments Download
M media/mojo/services/mojo_renderer_service.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M media/mojo/services/renderer_unittest.cc View 3 chunks +12 lines, -13 lines 0 comments Download
M media/video/capture/fake_video_capture_device.h View 1 chunk +4 lines, -5 lines 0 comments Download
M media/video/capture/fake_video_capture_device_factory.h View 1 chunk +4 lines, -4 lines 0 comments Download
M media/video/capture/file_video_capture_device.h View 1 chunk +4 lines, -5 lines 0 comments Download
M media/video/capture/file_video_capture_device_factory.h View 1 chunk +4 lines, -4 lines 0 comments Download
M media/video/capture/mac/video_capture_device_decklink_mac.h View 2 chunks +4 lines, -5 lines 0 comments Download
M media/video/capture/mac/video_capture_device_decklink_mac.mm View 2 chunks +7 lines, -7 lines 0 comments Download
M media/video/capture/mac/video_capture_device_factory_mac.h View 1 chunk +5 lines, -5 lines 0 comments Download
M media/video/capture/mac/video_capture_device_mac.h View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
dcheng
6 years, 2 months ago (2014-10-21 10:39:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/655713003/1
6 years, 2 months ago (2014-10-21 10:41:31 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-21 12:23:39 UTC) #4
commit-bot: I haz the power
6 years, 2 months ago (2014-10-21 13:09:51 UTC) #5
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/c24565478f64d1aa4d07e83c69d00bad11fa2665
Cr-Commit-Position: refs/heads/master@{#300471}

Powered by Google App Engine
This is Rietveld 408576698