Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Side by Side Diff: media/filters/video_renderer_impl.h

Issue 655713003: Standardize usage of virtual/override/final in media/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « media/filters/video_frame_scheduler_proxy.h ('k') | media/filters/vpx_video_decoder.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef MEDIA_FILTERS_VIDEO_RENDERER_IMPL_H_ 5 #ifndef MEDIA_FILTERS_VIDEO_RENDERER_IMPL_H_
6 #define MEDIA_FILTERS_VIDEO_RENDERER_IMPL_H_ 6 #define MEDIA_FILTERS_VIDEO_RENDERER_IMPL_H_
7 7
8 #include <deque> 8 #include <deque>
9 9
10 #include "base/memory/ref_counted.h" 10 #include "base/memory/ref_counted.h"
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
49 // down the video thread may result in losing synchronization with audio. 49 // down the video thread may result in losing synchronization with audio.
50 // 50 //
51 // Setting |drop_frames_| to true causes the renderer to drop expired frames. 51 // Setting |drop_frames_| to true causes the renderer to drop expired frames.
52 VideoRendererImpl( 52 VideoRendererImpl(
53 const scoped_refptr<base::SingleThreadTaskRunner>& task_runner, 53 const scoped_refptr<base::SingleThreadTaskRunner>& task_runner,
54 ScopedVector<VideoDecoder> decoders, 54 ScopedVector<VideoDecoder> decoders,
55 const SetDecryptorReadyCB& set_decryptor_ready_cb, 55 const SetDecryptorReadyCB& set_decryptor_ready_cb,
56 const PaintCB& paint_cb, 56 const PaintCB& paint_cb,
57 bool drop_frames, 57 bool drop_frames,
58 const scoped_refptr<MediaLog>& media_log); 58 const scoped_refptr<MediaLog>& media_log);
59 virtual ~VideoRendererImpl(); 59 ~VideoRendererImpl() override;
60 60
61 // VideoRenderer implementation. 61 // VideoRenderer implementation.
62 virtual void Initialize(DemuxerStream* stream, 62 void Initialize(DemuxerStream* stream,
63 bool low_delay, 63 bool low_delay,
64 const PipelineStatusCB& init_cb, 64 const PipelineStatusCB& init_cb,
65 const StatisticsCB& statistics_cb, 65 const StatisticsCB& statistics_cb,
66 const BufferingStateCB& buffering_state_cb, 66 const BufferingStateCB& buffering_state_cb,
67 const base::Closure& ended_cb, 67 const base::Closure& ended_cb,
68 const PipelineStatusCB& error_cb, 68 const PipelineStatusCB& error_cb,
69 const TimeDeltaCB& get_time_cb) override; 69 const TimeDeltaCB& get_time_cb) override;
70 virtual void Flush(const base::Closure& callback) override; 70 void Flush(const base::Closure& callback) override;
71 virtual void StartPlayingFrom(base::TimeDelta timestamp) override; 71 void StartPlayingFrom(base::TimeDelta timestamp) override;
72 72
73 // PlatformThread::Delegate implementation. 73 // PlatformThread::Delegate implementation.
74 virtual void ThreadMain() override; 74 void ThreadMain() override;
75 75
76 private: 76 private:
77 // Callback for |video_frame_stream_| initialization. 77 // Callback for |video_frame_stream_| initialization.
78 void OnVideoFrameStreamInitialized(bool success); 78 void OnVideoFrameStreamInitialized(bool success);
79 79
80 // Callback for |video_frame_stream_| to deliver decoded video frames and 80 // Callback for |video_frame_stream_| to deliver decoded video frames and
81 // report video decoding status. 81 // report video decoding status.
82 void FrameReady(VideoFrameStream::Status status, 82 void FrameReady(VideoFrameStream::Status status,
83 const scoped_refptr<VideoFrame>& frame); 83 const scoped_refptr<VideoFrame>& frame);
84 84
(...skipping 124 matching lines...) Expand 10 before | Expand all | Expand 10 after
209 209
210 // NOTE: Weak pointers must be invalidated before all other member variables. 210 // NOTE: Weak pointers must be invalidated before all other member variables.
211 base::WeakPtrFactory<VideoRendererImpl> weak_factory_; 211 base::WeakPtrFactory<VideoRendererImpl> weak_factory_;
212 212
213 DISALLOW_COPY_AND_ASSIGN(VideoRendererImpl); 213 DISALLOW_COPY_AND_ASSIGN(VideoRendererImpl);
214 }; 214 };
215 215
216 } // namespace media 216 } // namespace media
217 217
218 #endif // MEDIA_FILTERS_VIDEO_RENDERER_IMPL_H_ 218 #endif // MEDIA_FILTERS_VIDEO_RENDERER_IMPL_H_
OLDNEW
« no previous file with comments | « media/filters/video_frame_scheduler_proxy.h ('k') | media/filters/vpx_video_decoder.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698