Standardize usage of virtual/override/final in media/

media/cast/test/utility/udp_proxy.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <math.h>
 #include <stdlib.h>
 #include <vector>
 
 #include "media/cast/test/utility/udp_proxy.h"
 
@@ skipping 38 matching lines @@
  public:
   Buffer(size_t buffer_size, double max_megabits_per_second)
       : buffer_size_(0),
         max_buffer_size_(buffer_size),
         max_megabits_per_second_(max_megabits_per_second),
         weak_factory_(this) {
     CHECK_GT(max_buffer_size_, 0UL);
     CHECK_GT(max_megabits_per_second, 0);
   }
 
-  virtual void Send(scoped_ptr<Packet> packet) override {
+  void Send(scoped_ptr<Packet> packet) override {
     if (packet->size() + buffer_size_ <= max_buffer_size_) {
       buffer_size_ += packet->size();
       buffer_.push_back(linked_ptr<Packet>(packet.release()));
       if (buffer_.size() == 1) {
         Schedule();
       }
     }
   }
 
  private:
@@ skipping 39 matching lines @@
 
 scoped_ptr<PacketPipe> NewBuffer(size_t buffer_size, double bandwidth) {
   return scoped_ptr<PacketPipe>(new Buffer(buffer_size, bandwidth)).Pass();
 }
 
 class RandomDrop : public PacketPipe {
  public:
   RandomDrop(double drop_fraction)
       : drop_fraction_(static_cast<int>(drop_fraction * RAND_MAX)) {}
 
-  virtual void Send(scoped_ptr<Packet> packet) override {
+  void Send(scoped_ptr<Packet> packet) override {
     if (rand() > drop_fraction_) {
       pipe_->Send(packet.Pass());
     }
   }
 
  private:
   int drop_fraction_;
 };
 
 scoped_ptr<PacketPipe> NewRandomDrop(double drop_fraction) {
   return scoped_ptr<PacketPipe>(new RandomDrop(drop_fraction)).Pass();
 }
 
 class SimpleDelayBase : public PacketPipe {
  public:
   SimpleDelayBase() : weak_factory_(this) {}
-  virtual ~SimpleDelayBase() {}
+  ~SimpleDelayBase() override {}
 
-  virtual void Send(scoped_ptr<Packet> packet) override {
+  void Send(scoped_ptr<Packet> packet) override {
     double seconds = GetDelay();
     task_runner_->PostDelayedTask(
         FROM_HERE,
         base::Bind(&SimpleDelayBase::SendInternal,
                    weak_factory_.GetWeakPtr(),
                    base::Passed(&packet)),
         base::TimeDelta::FromMicroseconds(static_cast<int64>(seconds * 1E6)));
   }
  protected:
   virtual double GetDelay() = 0;
 
  private:
   virtual void SendInternal(scoped_ptr<Packet> packet) {
     pipe_->Send(packet.Pass());
   }
 
   base::WeakPtrFactory<SimpleDelayBase> weak_factory_;
 };
 
 class ConstantDelay : public SimpleDelayBase {
  public:
   ConstantDelay(double delay_seconds) : delay_seconds_(delay_seconds) {}
-  virtual double GetDelay() override {
-    return delay_seconds_;
-  }
+  double GetDelay() override { return delay_seconds_; }
 
  private:
   double delay_seconds_;
 };
 
 scoped_ptr<PacketPipe> NewConstantDelay(double delay_seconds) {
   return scoped_ptr<PacketPipe>(new ConstantDelay(delay_seconds)).Pass();
 }
 
 class RandomUnsortedDelay : public SimpleDelayBase {
  public:
   RandomUnsortedDelay(double random_delay) : random_delay_(random_delay) {}
 
-  virtual double GetDelay() override {
-    return random_delay_ * base::RandDouble();
-  }
+  double GetDelay() override { return random_delay_ * base::RandDouble(); }
 
  private:
   double random_delay_;
 };
 
 scoped_ptr<PacketPipe> NewRandomUnsortedDelay(double random_delay) {
   return scoped_ptr<PacketPipe>(new RandomUnsortedDelay(random_delay)).Pass();
 }
 
 class DuplicateAndDelay : public RandomUnsortedDelay {
  public:
   DuplicateAndDelay(double delay_min,
                     double random_delay) :
       RandomUnsortedDelay(random_delay),
       delay_min_(delay_min) {
   }
-  virtual void Send(scoped_ptr<Packet> packet) override {
+  void Send(scoped_ptr<Packet> packet) override {
     pipe_->Send(scoped_ptr<Packet>(new Packet(*packet.get())));
     RandomUnsortedDelay::Send(packet.Pass());
   }
-  virtual double GetDelay() override {
+  double GetDelay() override {
     return RandomUnsortedDelay::GetDelay() + delay_min_;
   }
  private:
   double delay_min_;
 };
 
 scoped_ptr<PacketPipe> NewDuplicateAndDelay(double delay_min,
                                             double random_delay) {
   return scoped_ptr<PacketPipe>(
       new DuplicateAndDelay(delay_min, random_delay)).Pass();
 }
 
 class RandomSortedDelay : public PacketPipe {
  public:
   RandomSortedDelay(double random_delay,
                     double extra_delay,
                     double seconds_between_extra_delay)
       : random_delay_(random_delay),
         extra_delay_(extra_delay),
         seconds_between_extra_delay_(seconds_between_extra_delay),
         weak_factory_(this) {}
 
-  virtual void Send(scoped_ptr<Packet> packet) override {
+  void Send(scoped_ptr<Packet> packet) override {
     buffer_.push_back(linked_ptr<Packet>(packet.release()));
     if (buffer_.size() == 1) {
       next_send_ = std::max(
           clock_->NowTicks() +
           base::TimeDelta::FromSecondsD(base::RandDouble() * random_delay_),
           next_send_);
       ProcessBuffer();
     }
   }
-  virtual void InitOnIOThread(
+  void InitOnIOThread(
       const scoped_refptr<base::SingleThreadTaskRunner>& task_runner,
       base::TickClock* clock) override {
     PacketPipe::InitOnIOThread(task_runner, clock);
     // As we start the stream, assume that we are in a random
     // place between two extra delays, thus multiplier = 1.0;
     ScheduleExtraDelay(1.0);
   }
 
  private:
   void ScheduleExtraDelay(double mult) {
@@ skipping 58 matching lines @@
 }
 
 class NetworkGlitchPipe : public PacketPipe {
  public:
   NetworkGlitchPipe(double average_work_time, double average_outage_time)
       : works_(false),
         max_work_time_(average_work_time * 2),
         max_outage_time_(average_outage_time * 2),
         weak_factory_(this) {}
 
-  virtual void InitOnIOThread(
+  void InitOnIOThread(
       const scoped_refptr<base::SingleThreadTaskRunner>& task_runner,
       base::TickClock* clock) override {
     PacketPipe::InitOnIOThread(task_runner, clock);
     Flip();
   }
 
-  virtual void Send(scoped_ptr<Packet> packet) override {
+  void Send(scoped_ptr<Packet> packet) override {
     if (works_) {
       pipe_->Send(packet.Pass());
     }
   }
 
  private:
   void Flip() {
     works_ = !works_;
     double seconds = base::RandDouble() *
         (works_ ? max_work_time_ : max_outage_time_);
@@ skipping 23 matching lines @@
  public:
   InternalBuffer(base::WeakPtr<InterruptedPoissonProcess> ipp,
                  size_t size)
       : ipp_(ipp),
         stored_size_(0),
         stored_limit_(size),
         clock_(NULL),
         weak_factory_(this) {
   }
 
-  virtual void Send(scoped_ptr<Packet> packet) override {
+  void Send(scoped_ptr<Packet> packet) override {
     // Drop if buffer is full.
     if (stored_size_ >= stored_limit_)
       return;
     stored_size_ += packet->size();
     buffer_.push_back(linked_ptr<Packet>(packet.release()));
     buffer_time_.push_back(clock_->NowTicks());
     DCHECK(buffer_.size() == buffer_time_.size());
   }
 
-  virtual void InitOnIOThread(
+  void InitOnIOThread(
       const scoped_refptr<base::SingleThreadTaskRunner>& task_runner,
       base::TickClock* clock) override {
     clock_ = clock;
     if (ipp_)
       ipp_->InitOnIOThread(task_runner, clock);
     PacketPipe::InitOnIOThread(task_runner, clock);
   }
 
   void SendOnePacket() {
     scoped_ptr<Packet> packet(buffer_.front().release());
@@ skipping 161 matching lines @@
     break;
   }
 }
 
 class UDPProxyImpl;
 
 class PacketSender : public PacketPipe {
  public:
   PacketSender(UDPProxyImpl* udp_proxy, const net::IPEndPoint* destination)
       : udp_proxy_(udp_proxy), destination_(destination) {}
-  virtual void Send(scoped_ptr<Packet> packet) override;
-  virtual void AppendToPipe(scoped_ptr<PacketPipe> pipe) override {
-    NOTREACHED();
-  }
+  void Send(scoped_ptr<Packet> packet) override;
+  void AppendToPipe(scoped_ptr<PacketPipe> pipe) override { NOTREACHED(); }
 
  private:
   UDPProxyImpl* udp_proxy_;
   const net::IPEndPoint* destination_;  // not owned
 };
 
 namespace {
 void BuildPipe(scoped_ptr<PacketPipe>* pipe, PacketPipe* next) {
   if (*pipe) {
     (*pipe)->AppendToPipe(scoped_ptr<PacketPipe>(next).Pass());
@@ skipping 86 matching lines @@
     base::WaitableEvent start_event(false, false);
     proxy_thread_.message_loop_proxy()->PostTask(
         FROM_HERE,
         base::Bind(&UDPProxyImpl::Start,
                    base::Unretained(this),
                    base::Unretained(&start_event),
                    net_log));
     start_event.Wait();
   }
 
-  virtual ~UDPProxyImpl() {
+  ~UDPProxyImpl() override {
     base::WaitableEvent stop_event(false, false);
     proxy_thread_.message_loop_proxy()->PostTask(
         FROM_HERE,
         base::Bind(&UDPProxyImpl::Stop,
                    base::Unretained(this),
                    base::Unretained(&stop_event)));
     stop_event.Wait();
     proxy_thread_.Stop();
   }
 
@@ skipping 154 matching lines @@
                                             destination,
                                             to_dest_pipe.Pass(),
                                             from_dest_pipe.Pass(),
                                             net_log));
   return ret.Pass();
 }
 
 }  // namespace test
 }  // namespace cast
 }  // namespace media