Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Unified Diff: media/base/pipeline.h

Issue 655713003: Standardize usage of virtual/override/final in media/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/fake_audio_renderer_sink.h ('k') | media/base/run_all_perftests.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/pipeline.h
diff --git a/media/base/pipeline.h b/media/base/pipeline.h
index 1ce4a4c46f603601f825d6d781e4f5cd2688e6f9..71c16e1ee0c4429d5e1c5597be65ccc41dc8b758 100644
--- a/media/base/pipeline.h
+++ b/media/base/pipeline.h
@@ -79,7 +79,7 @@ class MEDIA_EXPORT Pipeline : public DemuxerHost {
// Constructs a media pipeline that will execute on |task_runner|.
Pipeline(const scoped_refptr<base::SingleThreadTaskRunner>& task_runner,
MediaLog* media_log);
- virtual ~Pipeline();
+ ~Pipeline() override;
// Build a pipeline to using the given |demuxer| and |renderer| to construct
// a filter chain, executing |seek_cb| when the initial seek has completed.
@@ -203,13 +203,13 @@ class MEDIA_EXPORT Pipeline : public DemuxerHost {
void FinishSeek();
// DemuxerHost implementaion.
- virtual void AddBufferedTimeRange(base::TimeDelta start,
- base::TimeDelta end) override;
- virtual void SetDuration(base::TimeDelta duration) override;
- virtual void OnDemuxerError(PipelineStatus error) override;
- virtual void AddTextStream(DemuxerStream* text_stream,
- const TextTrackConfig& config) override;
- virtual void RemoveTextStream(DemuxerStream* text_stream) override;
+ void AddBufferedTimeRange(base::TimeDelta start,
+ base::TimeDelta end) override;
+ void SetDuration(base::TimeDelta duration) override;
+ void OnDemuxerError(PipelineStatus error) override;
+ void AddTextStream(DemuxerStream* text_stream,
+ const TextTrackConfig& config) override;
+ void RemoveTextStream(DemuxerStream* text_stream) override;
// Callback executed when a rendering error happened, initiating the teardown
// sequence.
« no previous file with comments | « media/base/fake_audio_renderer_sink.h ('k') | media/base/run_all_perftests.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698