Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1167)

Unified Diff: media/midi/midi_manager_unittest.cc

Issue 655713003: Standardize usage of virtual/override/final in media/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/midi/midi_manager_mac.h ('k') | media/midi/midi_manager_usb.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/midi/midi_manager_unittest.cc
diff --git a/media/midi/midi_manager_unittest.cc b/media/midi/midi_manager_unittest.cc
index cd81770e62dbf2d48cb647a97830bfcab09b4cbd..846e1bcfe64b8ef5f7c00e4af697328e9e679880 100644
--- a/media/midi/midi_manager_unittest.cc
+++ b/media/midi/midi_manager_unittest.cc
@@ -21,17 +21,17 @@ namespace {
class FakeMidiManager : public MidiManager {
public:
FakeMidiManager() : start_initialization_is_called_(false) {}
- virtual ~FakeMidiManager() {}
+ ~FakeMidiManager() override {}
// MidiManager implementation.
- virtual void StartInitialization() override {
+ void StartInitialization() override {
start_initialization_is_called_ = true;
}
- virtual void DispatchSendMidiData(MidiManagerClient* client,
- uint32 port_index,
- const std::vector<uint8>& data,
- double timestamp) override {}
+ void DispatchSendMidiData(MidiManagerClient* client,
+ uint32 port_index,
+ const std::vector<uint8>& data,
+ double timestamp) override {}
// Utility functions for testing.
void CallCompleteInitialization(MidiResult result) {
@@ -58,19 +58,21 @@ class FakeMidiManagerClient : public MidiManagerClient {
: client_id_(client_id),
result_(MIDI_NOT_SUPPORTED),
wait_for_result_(true) {}
- virtual ~FakeMidiManagerClient() {}
+ ~FakeMidiManagerClient() override {}
// MidiManagerClient implementation.
- virtual void CompleteStartSession(int client_id, MidiResult result) override {
+ void CompleteStartSession(int client_id, MidiResult result) override {
EXPECT_TRUE(wait_for_result_);
CHECK_EQ(client_id_, client_id);
result_ = result;
wait_for_result_ = false;
}
- virtual void ReceiveMidiData(uint32 port_index, const uint8* data,
- size_t size, double timestamp) override {}
- virtual void AccumulateMidiBytesSent(size_t size) override {}
+ void ReceiveMidiData(uint32 port_index,
+ const uint8* data,
+ size_t size,
+ double timestamp) override {}
+ void AccumulateMidiBytesSent(size_t size) override {}
int client_id() const { return client_id_; }
MidiResult result() const { return result_; }
« no previous file with comments | « media/midi/midi_manager_mac.h ('k') | media/midi/midi_manager_usb.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698