media/cast/logging/encoding_event_subscriber.h - Issue 655713003: Standardize usage of virtual/override/final in media/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/cast/logging/encoding_event_subscriber.h

Issue 655713003: Standardize usage of virtual/override/final in media/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/cast/logging/encoding_event_subscriber.h

diff --git a/media/cast/logging/encoding_event_subscriber.h b/media/cast/logging/encoding_event_subscriber.h

index 58dccbb73ee20189b271f5d6ca0a841a9c6bb31e..a67e5bca2bdab436ecb58c1e4044a69705837747 100644

--- a/media/cast/logging/encoding_event_subscriber.h

+++ b/media/cast/logging/encoding_event_subscriber.h

@@ -49,11 +49,11 @@ class EncodingEventSubscriber : public RawEventSubscriber {

// timestamp).

EncodingEventSubscriber(EventMediaType event_media_type, size_t max_frames);

- virtual ~EncodingEventSubscriber();

+ ~EncodingEventSubscriber() override;

// RawReventSubscriber implementations.

- virtual void OnReceiveFrameEvent(const FrameEvent& frame_event) override;

- virtual void OnReceivePacketEvent(const PacketEvent& packet_event) override;

+ void OnReceiveFrameEvent(const FrameEvent& frame_event) override;

+ void OnReceivePacketEvent(const PacketEvent& packet_event) override;

// Assigns frame events and packet events received so far to |frame_events|

// and |packet_events| and resets the internal state.

« no previous file with comments | « media/cast/cast_sender_impl.cc ('k') | media/cast/logging/receiver_time_offset_estimator.h » ('j') | no next file with comments »