media/video/capture/file_video_capture_device_factory.h - Issue 655713003: Standardize usage of virtual/override/final in media/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/video/capture/file_video_capture_device_factory.h

Issue 655713003: Standardize usage of virtual/override/final in media/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « media/video/capture/file_video_capture_device.h ('k') | media/video/capture/mac/video_capture_device_decklink_mac.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/video/capture/file_video_capture_device_factory.h

diff --git a/media/video/capture/file_video_capture_device_factory.h b/media/video/capture/file_video_capture_device_factory.h

index a696abe891723102a49e19dbecc785a3930abb54..523cd71b2cf8e78f39cc46641ef39710f022117b 100644

--- a/media/video/capture/file_video_capture_device_factory.h

+++ b/media/video/capture/file_video_capture_device_factory.h

@@ -16,12 +16,12 @@ class MEDIA_EXPORT FileVideoCaptureDeviceFactory :

public VideoCaptureDeviceFactory {

public:

FileVideoCaptureDeviceFactory() {}

- virtual ~FileVideoCaptureDeviceFactory() {}

+ ~FileVideoCaptureDeviceFactory() override {}

- virtual scoped_ptr<VideoCaptureDevice> Create(

+ scoped_ptr<VideoCaptureDevice> Create(

const VideoCaptureDevice::Name& device_name) override;

- virtual void GetDeviceNames(VideoCaptureDevice::Names* device_names) override;

- virtual void GetDeviceSupportedFormats(

+ void GetDeviceNames(VideoCaptureDevice::Names* device_names) override;

+ void GetDeviceSupportedFormats(

const VideoCaptureDevice::Name& device,

VideoCaptureFormats* supported_formats) override;

};

« no previous file with comments | « media/video/capture/file_video_capture_device.h ('k') | media/video/capture/mac/video_capture_device_decklink_mac.h » ('j') | no next file with comments »