Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: media/cast/sender/congestion_control.cc

Issue 655713003: Standardize usage of virtual/override/final in media/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/cast/sender/audio_sender_unittest.cc ('k') | media/cast/sender/external_video_encoder.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/cast/sender/congestion_control.cc
diff --git a/media/cast/sender/congestion_control.cc b/media/cast/sender/congestion_control.cc
index a3ebcf186017f63a91761697aad55adef453cf12..d14f9b08f3736c6234631ebf78e5f9cbfc7b11f7 100644
--- a/media/cast/sender/congestion_control.cc
+++ b/media/cast/sender/congestion_control.cc
@@ -29,23 +29,23 @@ class AdaptiveCongestionControl : public CongestionControl {
uint32 min_bitrate_configured,
double max_frame_rate);
- virtual ~AdaptiveCongestionControl() override;
+ ~AdaptiveCongestionControl() override;
- virtual void UpdateRtt(base::TimeDelta rtt) override;
+ void UpdateRtt(base::TimeDelta rtt) override;
- virtual void UpdateTargetPlayoutDelay(base::TimeDelta delay) override;
+ void UpdateTargetPlayoutDelay(base::TimeDelta delay) override;
// Called when an encoded frame is sent to the transport.
- virtual void SendFrameToTransport(uint32 frame_id,
- size_t frame_size,
- base::TimeTicks when) override;
+ void SendFrameToTransport(uint32 frame_id,
+ size_t frame_size,
+ base::TimeTicks when) override;
// Called when we receive an ACK for a frame.
- virtual void AckFrame(uint32 frame_id, base::TimeTicks when) override;
+ void AckFrame(uint32 frame_id, base::TimeTicks when) override;
// Returns the bitrate we should use for the next frame.
- virtual uint32 GetBitrate(base::TimeTicks playout_time,
- base::TimeDelta playout_delay) override;
+ uint32 GetBitrate(base::TimeTicks playout_time,
+ base::TimeDelta playout_delay) override;
private:
struct FrameStats {
@@ -96,27 +96,23 @@ class AdaptiveCongestionControl : public CongestionControl {
class FixedCongestionControl : public CongestionControl {
public:
FixedCongestionControl(uint32 bitrate) : bitrate_(bitrate) {}
- virtual ~FixedCongestionControl() override {}
+ ~FixedCongestionControl() override {}
- virtual void UpdateRtt(base::TimeDelta rtt) override {
- }
+ void UpdateRtt(base::TimeDelta rtt) override {}
- virtual void UpdateTargetPlayoutDelay(base::TimeDelta delay) override {
- }
+ void UpdateTargetPlayoutDelay(base::TimeDelta delay) override {}
// Called when an encoded frame is sent to the transport.
- virtual void SendFrameToTransport(uint32 frame_id,
- size_t frame_size,
- base::TimeTicks when) override {
- }
+ void SendFrameToTransport(uint32 frame_id,
+ size_t frame_size,
+ base::TimeTicks when) override {}
// Called when we receive an ACK for a frame.
- virtual void AckFrame(uint32 frame_id, base::TimeTicks when) override {
- }
+ void AckFrame(uint32 frame_id, base::TimeTicks when) override {}
// Returns the bitrate we should use for the next frame.
- virtual uint32 GetBitrate(base::TimeTicks playout_time,
- base::TimeDelta playout_delay) override {
+ uint32 GetBitrate(base::TimeTicks playout_time,
+ base::TimeDelta playout_delay) override {
return bitrate_;
}
« no previous file with comments | « media/cast/sender/audio_sender_unittest.cc ('k') | media/cast/sender/external_video_encoder.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698