Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(650)

Unified Diff: media/mojo/services/mojo_renderer_impl.h

Issue 655713003: Standardize usage of virtual/override/final in media/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/mojo/services/mojo_demuxer_stream_impl.h ('k') | media/mojo/services/mojo_renderer_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/mojo/services/mojo_renderer_impl.h
diff --git a/media/mojo/services/mojo_renderer_impl.h b/media/mojo/services/mojo_renderer_impl.h
index 87d7b9548e33995d5b8acad571bbb1187a177163..f70bb99c99c979595153a86ad6cbcbc85172b979 100644
--- a/media/mojo/services/mojo_renderer_impl.h
+++ b/media/mojo/services/mojo_renderer_impl.h
@@ -37,30 +37,29 @@ class MojoRendererImpl : public Renderer, public mojo::MediaRendererClient {
MojoRendererImpl(
const scoped_refptr<base::SingleThreadTaskRunner>& task_runner,
mojo::ServiceProvider* audio_renderer_provider);
- virtual ~MojoRendererImpl();
+ ~MojoRendererImpl() override;
// Renderer implementation.
- virtual void Initialize(DemuxerStreamProvider* demuxer_stream_provider,
- const base::Closure& init_cb,
- const StatisticsCB& statistics_cb,
- const base::Closure& ended_cb,
- const PipelineStatusCB& error_cb,
- const BufferingStateCB& buffering_state_cb) override;
- virtual void Flush(const base::Closure& flush_cb) override;
- virtual void StartPlayingFrom(base::TimeDelta time) override;
- virtual void SetPlaybackRate(float playback_rate) override;
- virtual void SetVolume(float volume) override;
- virtual base::TimeDelta GetMediaTime() override;
- virtual bool HasAudio() override;
- virtual bool HasVideo() override;
- virtual void SetCdm(MediaKeys* cdm) override;
+ void Initialize(DemuxerStreamProvider* demuxer_stream_provider,
+ const base::Closure& init_cb,
+ const StatisticsCB& statistics_cb,
+ const base::Closure& ended_cb,
+ const PipelineStatusCB& error_cb,
+ const BufferingStateCB& buffering_state_cb) override;
+ void Flush(const base::Closure& flush_cb) override;
+ void StartPlayingFrom(base::TimeDelta time) override;
+ void SetPlaybackRate(float playback_rate) override;
+ void SetVolume(float volume) override;
+ base::TimeDelta GetMediaTime() override;
+ bool HasAudio() override;
+ bool HasVideo() override;
+ void SetCdm(MediaKeys* cdm) override;
// mojo::MediaRendererClient implementation.
- virtual void OnTimeUpdate(int64_t time_usec,
- int64_t max_time_usec) override;
- virtual void OnBufferingStateChange(mojo::BufferingState state) override;
- virtual void OnEnded() override;
- virtual void OnError() override;
+ void OnTimeUpdate(int64_t time_usec, int64_t max_time_usec) override;
+ void OnBufferingStateChange(mojo::BufferingState state) override;
+ void OnEnded() override;
+ void OnError() override;
private:
// Called when |remote_audio_renderer_| has finished initializing.
« no previous file with comments | « media/mojo/services/mojo_demuxer_stream_impl.h ('k') | media/mojo/services/mojo_renderer_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698