Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Side by Side Diff: media/cast/sender/external_video_encoder.h

Issue 655713003: Standardize usage of virtual/override/final in media/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « media/cast/sender/congestion_control.cc ('k') | media/cast/sender/external_video_encoder.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef MEDIA_CAST_SENDER_EXTERNAL_VIDEO_ENCODER_H_ 5 #ifndef MEDIA_CAST_SENDER_EXTERNAL_VIDEO_ENCODER_H_
6 #define MEDIA_CAST_SENDER_EXTERNAL_VIDEO_ENCODER_H_ 6 #define MEDIA_CAST_SENDER_EXTERNAL_VIDEO_ENCODER_H_
7 7
8 #include "base/memory/scoped_ptr.h" 8 #include "base/memory/scoped_ptr.h"
9 #include "base/memory/weak_ptr.h" 9 #include "base/memory/weak_ptr.h"
10 #include "media/cast/cast_config.h" 10 #include "media/cast/cast_config.h"
(...skipping 14 matching lines...) Expand all
25 // the video encoder thread. 25 // the video encoder thread.
26 class ExternalVideoEncoder : public VideoEncoder { 26 class ExternalVideoEncoder : public VideoEncoder {
27 public: 27 public:
28 ExternalVideoEncoder( 28 ExternalVideoEncoder(
29 scoped_refptr<CastEnvironment> cast_environment, 29 scoped_refptr<CastEnvironment> cast_environment,
30 const VideoSenderConfig& video_config, 30 const VideoSenderConfig& video_config,
31 const CastInitializationCallback& initialization_cb, 31 const CastInitializationCallback& initialization_cb,
32 const CreateVideoEncodeAcceleratorCallback& create_vea_cb, 32 const CreateVideoEncodeAcceleratorCallback& create_vea_cb,
33 const CreateVideoEncodeMemoryCallback& create_video_encode_mem_cb); 33 const CreateVideoEncodeMemoryCallback& create_video_encode_mem_cb);
34 34
35 virtual ~ExternalVideoEncoder(); 35 ~ExternalVideoEncoder() override;
36 36
37 // VideoEncoder implementation. 37 // VideoEncoder implementation.
38 virtual bool EncodeVideoFrame( 38 bool EncodeVideoFrame(
39 const scoped_refptr<media::VideoFrame>& video_frame, 39 const scoped_refptr<media::VideoFrame>& video_frame,
40 const base::TimeTicks& reference_time, 40 const base::TimeTicks& reference_time,
41 const FrameEncodedCallback& frame_encoded_callback) override; 41 const FrameEncodedCallback& frame_encoded_callback) override;
42 virtual void SetBitRate(int new_bit_rate) override; 42 void SetBitRate(int new_bit_rate) override;
43 virtual void GenerateKeyFrame() override; 43 void GenerateKeyFrame() override;
44 virtual void LatestFrameIdToReference(uint32 frame_id) override; 44 void LatestFrameIdToReference(uint32 frame_id) override;
45 45
46 // Called when video_accelerator_client_ has finished creating the VEA and 46 // Called when video_accelerator_client_ has finished creating the VEA and
47 // is ready for use. 47 // is ready for use.
48 void OnCreateVideoEncodeAccelerator( 48 void OnCreateVideoEncodeAccelerator(
49 scoped_refptr<base::SingleThreadTaskRunner> encoder_task_runner); 49 scoped_refptr<base::SingleThreadTaskRunner> encoder_task_runner);
50 50
51 protected: 51 protected:
52 // If |success| is true then encoder is initialized successfully. 52 // If |success| is true then encoder is initialized successfully.
53 // Otherwise encoder initialization failed. 53 // Otherwise encoder initialization failed.
54 void EncoderInitialized(bool success); 54 void EncoderInitialized(bool success);
(...skipping 18 matching lines...) Expand all
73 // NOTE: Weak pointers must be invalidated before all other member variables. 73 // NOTE: Weak pointers must be invalidated before all other member variables.
74 base::WeakPtrFactory<ExternalVideoEncoder> weak_factory_; 74 base::WeakPtrFactory<ExternalVideoEncoder> weak_factory_;
75 75
76 DISALLOW_COPY_AND_ASSIGN(ExternalVideoEncoder); 76 DISALLOW_COPY_AND_ASSIGN(ExternalVideoEncoder);
77 }; 77 };
78 78
79 } // namespace cast 79 } // namespace cast
80 } // namespace media 80 } // namespace media
81 81
82 #endif // MEDIA_CAST_SENDER_EXTERNAL_VIDEO_ENCODER_H_ 82 #endif // MEDIA_CAST_SENDER_EXTERNAL_VIDEO_ENCODER_H_
OLDNEW
« no previous file with comments | « media/cast/sender/congestion_control.cc ('k') | media/cast/sender/external_video_encoder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698