Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1018)

Issue 654933002: Use exactly one of final, override, and virtual (Closed)

Created:
6 years, 2 months ago by Mark Mentovai
Modified:
6 years, 2 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Project:
crashpad
Visibility:
Public.

Description

Use exactly one of final, override, and virtual. This change was generated mechanically by running: find . \ \( -name \*.cc -or -name \*.mm -or -name \*.h \) \ -and -not -path ./third_party/\* -and -not -path ./out/\* -exec \ sed -i '' -E -e 's/virtual (.*) override final/\1 final/' {} + find . \ \( -name \*.cc -or -name \*.mm -or -name \*.h \) \ -and -not -path ./third_party/\* -and -not -path ./out/\* -exec \ sed -i '' -E -e 's/virtual (.*) override/\1 override/' {} + Additional changes were made manually based on: git grep -E '^ {3,}.*override[;{]' http://google-styleguide.googlecode.com/svn/trunk/cppguide.html?showone=The__define_Guard#Inheritance TEST=*_test BUG= R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/525de2c35a376787e084e4028e952792b1d5b85a

Patch Set 1 : sed -i '' -E -e 's/virtual (.*) override final/\1 final/' #

Patch Set 2 : sed -i '' -E -e 's/virtual (.*) override/\1 override/' #

Patch Set 3 : git grep -E '^ {3,}.*override[ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+203 lines, -210 lines) Patch
M minidump/minidump_context_writer.h View 1 3 chunks +6 lines, -6 lines 0 comments Download
M minidump/minidump_exception_writer.h View 1 1 chunk +5 lines, -5 lines 0 comments Download
M minidump/minidump_file_writer.h View 1 1 chunk +6 lines, -6 lines 0 comments Download
M minidump/minidump_file_writer_test.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M minidump/minidump_memory_writer.h View 1 4 chunks +10 lines, -10 lines 0 comments Download
M minidump/minidump_memory_writer_test.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M minidump/minidump_memory_writer_test_util.h View 1 1 chunk +4 lines, -4 lines 0 comments Download
M minidump/minidump_misc_info_writer.h View 1 1 chunk +4 lines, -4 lines 0 comments Download
M minidump/minidump_module_writer.h View 1 4 chunks +14 lines, -14 lines 0 comments Download
M minidump/minidump_stream_writer.h View 1 1 chunk +1 line, -1 line 0 comments Download
M minidump/minidump_string_writer.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M minidump/minidump_system_info_writer.h View 1 1 chunk +5 lines, -5 lines 0 comments Download
M minidump/minidump_thread_writer.h View 1 2 chunks +9 lines, -9 lines 0 comments Download
M minidump/minidump_writable_test.cc View 1 7 chunks +12 lines, -12 lines 0 comments Download
M snapshot/exception_snapshot_mac.h View 1 1 chunk +6 lines, -6 lines 0 comments Download
M snapshot/memory_snapshot_mac.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M snapshot/system_snapshot_mac.h View 1 2 1 chunk +22 lines, -25 lines 0 comments Download
M snapshot/system_snapshot_mac_test.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M snapshot/thread_snapshot_mac.h View 1 1 chunk +6 lines, -6 lines 0 comments Download
M util/file/file_writer.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M util/file/string_file_writer.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M util/mach/exc_client_variants_test.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M util/mach/exc_server_variants.h View 1 2 7 chunks +46 lines, -50 lines 0 comments Download
M util/mach/exc_server_variants_test.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M util/mach/exception_ports_test.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M util/mach/mach_message_server_test.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M util/mach/scoped_task_suspend_test.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M util/test/mac/mach_multiprocess.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M util/test/mac/mach_multiprocess_test.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M util/test/multiprocess.h View 1 1 chunk +1 line, -1 line 0 comments Download
M util/test/multiprocess_exec.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M util/test/multiprocess_exec_test.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M util/test/multiprocess_test.cc View 1 5 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Mark Mentovai
6 years, 2 months ago (2014-10-14 14:02:13 UTC) #3
Robert Sesek
LGTM
6 years, 2 months ago (2014-10-14 14:43:58 UTC) #4
Mark Mentovai
6 years, 2 months ago (2014-10-14 15:12:00 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:60001) manually as
525de2c35a376787e084e4028e952792b1d5b85a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698