Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(533)

Unified Diff: util/file/file_writer.h

Issue 654933002: Use exactly one of final, override, and virtual (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: git grep -E '^ {3,}.*override[ Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « snapshot/thread_snapshot_mac.h ('k') | util/file/string_file_writer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: util/file/file_writer.h
diff --git a/util/file/file_writer.h b/util/file/file_writer.h
index e454848d78714530b934320e846bb2cfe5e3b1c4..54c59c923378f58f9e8bffe5a8207e9ae764b0c4 100644
--- a/util/file/file_writer.h
+++ b/util/file/file_writer.h
@@ -105,19 +105,19 @@ class FileWriter : public FileWriterInterface {
//!
//! \note It is only valid to call this method between a successful Open() and
//! a Close().
- virtual bool Write(const void* data, size_t size) override;
+ bool Write(const void* data, size_t size) override;
//! \copydoc FileWriterInterface::WriteIoVec()
//!
//! \note It is only valid to call this method between a successful Open() and
//! a Close().
- virtual bool WriteIoVec(std::vector<WritableIoVec>* iovecs) override;
+ bool WriteIoVec(std::vector<WritableIoVec>* iovecs) override;
//! \copydoc FileWriterInterface::Seek()
//!
//! \note It is only valid to call this method between a successful Open() and
//! a Close().
- virtual off_t Seek(off_t offset, int whence) override;
+ off_t Seek(off_t offset, int whence) override;
private:
base::ScopedFD fd_;
« no previous file with comments | « snapshot/thread_snapshot_mac.h ('k') | util/file/string_file_writer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698