minidump/minidump_memory_writer_test_util.h - Issue 654933002: Use exactly one of final, override, and virtual

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: minidump/minidump_memory_writer_test_util.h

Issue 654933002: Use exactly one of final, override, and virtual (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: git grep -E '^ {3,}.*override[ Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: minidump/minidump_memory_writer_test_util.h

diff --git a/minidump/minidump_memory_writer_test_util.h b/minidump/minidump_memory_writer_test_util.h

index 69b2aebbb36673bb29b5b8de89023cbdbe25c03e..5299f68708c30e5e4efa8d5003cc35cac79956b7 100644

--- a/minidump/minidump_memory_writer_test_util.h

+++ b/minidump/minidump_memory_writer_test_util.h

@@ -39,12 +39,12 @@ class TestMinidumpMemoryWriter final : public MinidumpMemoryWriter {

protected:

// MinidumpMemoryWriter:

- virtual uint64_t MemoryRangeBaseAddress() const override;

- virtual size_t MemoryRangeSize() const override;

+ uint64_t MemoryRangeBaseAddress() const override;

+ size_t MemoryRangeSize() const override;

// MinidumpWritable:

- virtual bool WillWriteAtOffsetImpl(off_t offset) override;

- virtual bool WriteObject(FileWriterInterface* file_writer) override;

+ bool WillWriteAtOffsetImpl(off_t offset) override;

+ bool WriteObject(FileWriterInterface* file_writer) override;

private:

uint64_t base_address_;

« no previous file with comments | « minidump/minidump_memory_writer_test.cc ('k') | minidump/minidump_misc_info_writer.h » ('j') | no next file with comments »