Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Unified Diff: minidump/minidump_file_writer.h

Issue 654933002: Use exactly one of final, override, and virtual (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: git grep -E '^ {3,}.*override[ Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « minidump/minidump_exception_writer.h ('k') | minidump/minidump_file_writer_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: minidump/minidump_file_writer.h
diff --git a/minidump/minidump_file_writer.h b/minidump/minidump_file_writer.h
index bc9753d2c2deae1af2f6628dfab0d1c522ba47ad..2faa35b03bae1d4b54f2df71edf0f688886c9101 100644
--- a/minidump/minidump_file_writer.h
+++ b/minidump/minidump_file_writer.h
@@ -62,15 +62,15 @@ class MinidumpFileWriter final : public internal::MinidumpWritable {
//! rewinds to the beginning of the file and writes the correct value for this
//! field. This prevents incompletely-written minidump files from being
//! mistaken for valid ones.
- virtual bool WriteEverything(FileWriterInterface* file_writer) override;
+ bool WriteEverything(FileWriterInterface* file_writer) override;
protected:
// MinidumpWritable:
- virtual bool Freeze() override;
- virtual size_t SizeOfObject() override;
- virtual std::vector<MinidumpWritable*> Children() override;
- virtual bool WillWriteAtOffsetImpl(off_t offset) override;
- virtual bool WriteObject(FileWriterInterface* file_writer) override;
+ bool Freeze() override;
+ size_t SizeOfObject() override;
+ std::vector<MinidumpWritable*> Children() override;
+ bool WillWriteAtOffsetImpl(off_t offset) override;
+ bool WriteObject(FileWriterInterface* file_writer) override;
private:
MINIDUMP_HEADER header_;
« no previous file with comments | « minidump/minidump_exception_writer.h ('k') | minidump/minidump_file_writer_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698