Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1082)

Unified Diff: util/test/multiprocess_test.cc

Issue 654933002: Use exactly one of final, override, and virtual (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: git grep -E '^ {3,}.*override[ Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « util/test/multiprocess_exec_test.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: util/test/multiprocess_test.cc
diff --git a/util/test/multiprocess_test.cc b/util/test/multiprocess_test.cc
index a766585462263806550d36ff0f699c4e1e65b97b..92dc6cfc6e157cc4423b6e2d4880b61a08851d36 100644
--- a/util/test/multiprocess_test.cc
+++ b/util/test/multiprocess_test.cc
@@ -35,7 +35,7 @@ class TestMultiprocess final : public Multiprocess {
private:
// Multiprocess:
- virtual void MultiprocessParent() override {
+ void MultiprocessParent() override {
int read_fd = ReadPipeFD();
char c;
CheckedReadFD(read_fd, &c, 1);
@@ -53,7 +53,7 @@ class TestMultiprocess final : public Multiprocess {
CheckedReadFDAtEOF(read_fd);
}
- virtual void MultiprocessChild() override {
+ void MultiprocessChild() override {
int write_fd = WritePipeFD();
char c = 'M';
@@ -102,10 +102,10 @@ class TestMultiprocessUnclean final : public Multiprocess {
// Multiprocess:
- virtual void MultiprocessParent() override {
+ void MultiprocessParent() override {
}
- virtual void MultiprocessChild() override {
+ void MultiprocessChild() override {
if (type_ == kAbort) {
abort();
} else {
@@ -216,7 +216,7 @@ class TestMultiprocessClosePipe final : public Multiprocess {
// Multiprocess:
- virtual void MultiprocessParent() override {
+ void MultiprocessParent() override {
ASSERT_NO_FATAL_FAILURE(VerifyInitial());
if (who_closes_ == kParentCloses) {
@@ -226,7 +226,7 @@ class TestMultiprocessClosePipe final : public Multiprocess {
}
}
- virtual void MultiprocessChild() override {
+ void MultiprocessChild() override {
ASSERT_NO_FATAL_FAILURE(VerifyInitial());
if (who_closes_ == kChildCloses) {
« no previous file with comments | « util/test/multiprocess_exec_test.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698