Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Side by Side Diff: minidump/minidump_misc_info_writer.h

Issue 654933002: Use exactly one of final, override, and virtual (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: git grep -E '^ {3,}.*override[ Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « minidump/minidump_memory_writer_test_util.h ('k') | minidump/minidump_module_writer.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Crashpad Authors. All rights reserved. 1 // Copyright 2014 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
75 const std::string& daylight_name, 75 const std::string& daylight_name,
76 const SYSTEMTIME& daylight_date, 76 const SYSTEMTIME& daylight_date,
77 int32_t daylight_bias); 77 int32_t daylight_bias);
78 78
79 //! \brief Sets the fields referenced by #MINIDUMP_MISC4_BUILDSTRING. 79 //! \brief Sets the fields referenced by #MINIDUMP_MISC4_BUILDSTRING.
80 void SetBuildString(const std::string& build_string, 80 void SetBuildString(const std::string& build_string,
81 const std::string& debug_build_string); 81 const std::string& debug_build_string);
82 82
83 protected: 83 protected:
84 // MinidumpWritable: 84 // MinidumpWritable:
85 virtual bool Freeze() override; 85 bool Freeze() override;
86 virtual size_t SizeOfObject() override; 86 size_t SizeOfObject() override;
87 virtual bool WriteObject(FileWriterInterface* file_writer) override; 87 bool WriteObject(FileWriterInterface* file_writer) override;
88 virtual MinidumpStreamType StreamType() const override; 88 MinidumpStreamType StreamType() const override;
89 89
90 private: 90 private:
91 //! \brief Returns the size of the object to be written based on 91 //! \brief Returns the size of the object to be written based on
92 //! MINIDUMP_MISC_INFO_N::Flags1. 92 //! MINIDUMP_MISC_INFO_N::Flags1.
93 //! 93 //!
94 //! The smallest defined structure type in the MINIDUMP_MISC_INFO family that 94 //! The smallest defined structure type in the MINIDUMP_MISC_INFO family that
95 //! can hold all of the data that has been populated will be used. 95 //! can hold all of the data that has been populated will be used.
96 size_t CalculateSizeOfObjectFromFlags() const; 96 size_t CalculateSizeOfObjectFromFlags() const;
97 97
98 MINIDUMP_MISC_INFO_N misc_info_; 98 MINIDUMP_MISC_INFO_N misc_info_;
99 99
100 DISALLOW_COPY_AND_ASSIGN(MinidumpMiscInfoWriter); 100 DISALLOW_COPY_AND_ASSIGN(MinidumpMiscInfoWriter);
101 }; 101 };
102 102
103 } // namespace crashpad 103 } // namespace crashpad
104 104
105 #endif // CRASHPAD_MINIDUMP_MINIDUMP_MISC_INFO_WRITER_H_ 105 #endif // CRASHPAD_MINIDUMP_MINIDUMP_MISC_INFO_WRITER_H_
OLDNEW
« no previous file with comments | « minidump/minidump_memory_writer_test_util.h ('k') | minidump/minidump_module_writer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698