Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Unified Diff: snapshot/system_snapshot_mac.h

Issue 654933002: Use exactly one of final, override, and virtual (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: git grep -E '^ {3,}.*override[ Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « snapshot/memory_snapshot_mac.h ('k') | snapshot/system_snapshot_mac_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: snapshot/system_snapshot_mac.h
diff --git a/snapshot/system_snapshot_mac.h b/snapshot/system_snapshot_mac.h
index 104c6da834c8308e3aebef19b893dc02448b411a..3eadc372952fb03641bcd686e466bcbe9e8ff297 100644
--- a/snapshot/system_snapshot_mac.h
+++ b/snapshot/system_snapshot_mac.h
@@ -58,31 +58,28 @@ class SystemSnapshotMac final : public SystemSnapshot {
// SystemSnapshot:
- virtual CPUArchitecture GetCPUArchitecture() const override;
- virtual uint32_t CPURevision() const override;
- virtual uint8_t CPUCount() const override;
- virtual std::string CPUVendor() const override;
- virtual void CPUFrequency(uint64_t* current_hz,
- uint64_t* max_hz) const override;
- virtual uint32_t CPUX86Signature() const override;
- virtual uint64_t CPUX86Features() const override;
- virtual uint64_t CPUX86ExtendedFeatures() const override;
- virtual uint32_t CPUX86Leaf7Features() const override;
- virtual bool CPUX86SupportsDAZ() const override;
- virtual OperatingSystem GetOperatingSystem() const override;
- virtual bool OSServer() const override;
- virtual void OSVersion(int* major,
- int* minor,
- int* bugfix,
- std::string* build) const override;
- virtual std::string OSVersionFull() const override;
- virtual bool NXEnabled() const override;
- virtual std::string MachineDescription() const override;
- virtual void TimeZone(DaylightSavingTimeStatus* dst_status,
- int* standard_offset_seconds,
- int* daylight_offset_seconds,
- std::string* standard_name,
- std::string* daylight_name) const override;
+ CPUArchitecture GetCPUArchitecture() const override;
+ uint32_t CPURevision() const override;
+ uint8_t CPUCount() const override;
+ std::string CPUVendor() const override;
+ void CPUFrequency(uint64_t* current_hz, uint64_t* max_hz) const override;
+ uint32_t CPUX86Signature() const override;
+ uint64_t CPUX86Features() const override;
+ uint64_t CPUX86ExtendedFeatures() const override;
+ uint32_t CPUX86Leaf7Features() const override;
+ bool CPUX86SupportsDAZ() const override;
+ OperatingSystem GetOperatingSystem() const override;
+ bool OSServer() const override;
+ void OSVersion(
+ int* major, int* minor, int* bugfix, std::string* build) const override;
+ std::string OSVersionFull() const override;
+ bool NXEnabled() const override;
+ std::string MachineDescription() const override;
+ void TimeZone(DaylightSavingTimeStatus* dst_status,
+ int* standard_offset_seconds,
+ int* daylight_offset_seconds,
+ std::string* standard_name,
+ std::string* daylight_name) const override;
private:
std::string os_version_full_;
« no previous file with comments | « snapshot/memory_snapshot_mac.h ('k') | snapshot/system_snapshot_mac_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698