Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Side by Side Diff: minidump/minidump_memory_writer_test_util.h

Issue 654933002: Use exactly one of final, override, and virtual (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: git grep -E '^ {3,}.*override[ Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « minidump/minidump_memory_writer_test.cc ('k') | minidump/minidump_misc_info_writer.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Crashpad Authors. All rights reserved. 1 // Copyright 2014 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
(...skipping 21 matching lines...) Expand all
32 //! 32 //!
33 //! TestMinidumpMemoryWriter objects are created with a fixed base address and 33 //! TestMinidumpMemoryWriter objects are created with a fixed base address and
34 //! size, and will write the same byte (\a value) repeatedly, \a size times. 34 //! size, and will write the same byte (\a value) repeatedly, \a size times.
35 class TestMinidumpMemoryWriter final : public MinidumpMemoryWriter { 35 class TestMinidumpMemoryWriter final : public MinidumpMemoryWriter {
36 public: 36 public:
37 TestMinidumpMemoryWriter(uint64_t base_address, size_t size, uint8_t value); 37 TestMinidumpMemoryWriter(uint64_t base_address, size_t size, uint8_t value);
38 ~TestMinidumpMemoryWriter(); 38 ~TestMinidumpMemoryWriter();
39 39
40 protected: 40 protected:
41 // MinidumpMemoryWriter: 41 // MinidumpMemoryWriter:
42 virtual uint64_t MemoryRangeBaseAddress() const override; 42 uint64_t MemoryRangeBaseAddress() const override;
43 virtual size_t MemoryRangeSize() const override; 43 size_t MemoryRangeSize() const override;
44 44
45 // MinidumpWritable: 45 // MinidumpWritable:
46 virtual bool WillWriteAtOffsetImpl(off_t offset) override; 46 bool WillWriteAtOffsetImpl(off_t offset) override;
47 virtual bool WriteObject(FileWriterInterface* file_writer) override; 47 bool WriteObject(FileWriterInterface* file_writer) override;
48 48
49 private: 49 private:
50 uint64_t base_address_; 50 uint64_t base_address_;
51 off_t expected_offset_; 51 off_t expected_offset_;
52 size_t size_; 52 size_t size_;
53 uint8_t value_; 53 uint8_t value_;
54 54
55 DISALLOW_COPY_AND_ASSIGN(TestMinidumpMemoryWriter); 55 DISALLOW_COPY_AND_ASSIGN(TestMinidumpMemoryWriter);
56 }; 56 };
57 57
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
95 const MINIDUMP_MEMORY_DESCRIPTOR* expected, 95 const MINIDUMP_MEMORY_DESCRIPTOR* expected,
96 const MINIDUMP_MEMORY_DESCRIPTOR* observed, 96 const MINIDUMP_MEMORY_DESCRIPTOR* observed,
97 const std::string& file_contents, 97 const std::string& file_contents,
98 uint8_t value, 98 uint8_t value,
99 bool at_eof); 99 bool at_eof);
100 100
101 } // namespace test 101 } // namespace test
102 } // namespace crashpad 102 } // namespace crashpad
103 103
104 #endif // CRASHPAD_MINIDUMP_MINIDUMP_MEMORY_WRITER_TEST_UTIL_H_ 104 #endif // CRASHPAD_MINIDUMP_MINIDUMP_MEMORY_WRITER_TEST_UTIL_H_
OLDNEW
« no previous file with comments | « minidump/minidump_memory_writer_test.cc ('k') | minidump/minidump_misc_info_writer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698