Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(747)

Side by Side Diff: util/mach/exc_client_variants_test.cc

Issue 654933002: Use exactly one of final, override, and virtual (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: git grep -E '^ {3,}.*override[ Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « util/file/string_file_writer.h ('k') | util/mach/exc_server_variants.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Crashpad Authors. All rights reserved. 1 // Copyright 2014 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
(...skipping 115 matching lines...) Expand 10 before | Expand all | Expand 10 after
126 EXPECT_EQ(0u, *new_state_count); 126 EXPECT_EQ(0u, *new_state_count);
127 EXPECT_EQ(NULL, new_state); 127 EXPECT_EQ(NULL, new_state);
128 } 128 }
129 129
130 return KERN_SUCCESS; 130 return KERN_SUCCESS;
131 } 131 }
132 132
133 private: 133 private:
134 // MachMultiprocess: 134 // MachMultiprocess:
135 135
136 virtual void MachMultiprocessParent() override { 136 void MachMultiprocessParent() override {
137 kern_return_t kr = MachMessageServer::Run(this, 137 kern_return_t kr = MachMessageServer::Run(this,
138 LocalPort(), 138 LocalPort(),
139 MACH_MSG_OPTION_NONE, 139 MACH_MSG_OPTION_NONE,
140 MachMessageServer::kOneShot, 140 MachMessageServer::kOneShot,
141 MachMessageServer::kBlocking, 141 MachMessageServer::kBlocking,
142 0); 142 0);
143 EXPECT_EQ(KERN_SUCCESS, kr) 143 EXPECT_EQ(KERN_SUCCESS, kr)
144 << MachErrorMessage(kr, "MachMessageServer::Run"); 144 << MachErrorMessage(kr, "MachMessageServer::Run");
145 145
146 EXPECT_TRUE(handled_); 146 EXPECT_TRUE(handled_);
147 } 147 }
148 148
149 virtual void MachMultiprocessChild() override { 149 void MachMultiprocessChild() override {
150 const exception_type_t exception = exception_; 150 const exception_type_t exception = exception_;
151 const mach_exception_data_type_t code[] = { 151 const mach_exception_data_type_t code[] = {
152 exception_code_, 152 exception_code_,
153 exception_subcode_ 153 exception_subcode_
154 }; 154 };
155 155
156 thread_t thread = THREAD_NULL; 156 thread_t thread = THREAD_NULL;
157 task_t task = TASK_NULL; 157 task_t task = TASK_NULL;
158 if (all_fields_ || HasIdentity()) { 158 if (all_fields_ || HasIdentity()) {
159 thread = MachThreadSelf(); 159 thread = MachThreadSelf();
(...skipping 121 matching lines...) Expand 10 before | Expand all | Expand 10 after
281 281
282 TestExcClientVariants test_exc_client_variants(behavior, true); 282 TestExcClientVariants test_exc_client_variants(behavior, true);
283 test_exc_client_variants.Run(); 283 test_exc_client_variants.Run();
284 } 284 }
285 } 285 }
286 } 286 }
287 287
288 } // namespace 288 } // namespace
289 } // namespace test 289 } // namespace test
290 } // namespace crashpad 290 } // namespace crashpad
OLDNEW
« no previous file with comments | « util/file/string_file_writer.h ('k') | util/mach/exc_server_variants.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698