Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Unified Diff: minidump/minidump_context_writer.h

Issue 654933002: Use exactly one of final, override, and virtual (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: git grep -E '^ {3,}.*override[ Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | minidump/minidump_exception_writer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: minidump/minidump_context_writer.h
diff --git a/minidump/minidump_context_writer.h b/minidump/minidump_context_writer.h
index 91e7367b022e7eabf571f3f14d4d067b75273a13..3b50b36075a029b4bc9087c17c59310ef248a953 100644
--- a/minidump/minidump_context_writer.h
+++ b/minidump/minidump_context_writer.h
@@ -41,7 +41,7 @@ class MinidumpContextWriter : public internal::MinidumpWritable {
virtual size_t ContextSize() const = 0;
// MinidumpWritable:
- virtual size_t SizeOfObject() override final;
+ size_t SizeOfObject() final;
private:
DISALLOW_COPY_AND_ASSIGN(MinidumpContextWriter);
@@ -67,10 +67,10 @@ class MinidumpContextX86Writer final : public MinidumpContextWriter {
protected:
// MinidumpWritable:
- virtual bool WriteObject(FileWriterInterface* file_writer) override;
+ bool WriteObject(FileWriterInterface* file_writer) override;
// MinidumpContextWriter:
- virtual size_t ContextSize() const override;
+ size_t ContextSize() const override;
private:
MinidumpContextX86 context_;
@@ -98,11 +98,11 @@ class MinidumpContextAMD64Writer final : public MinidumpContextWriter {
protected:
// MinidumpWritable:
- virtual size_t Alignment() override;
- virtual bool WriteObject(FileWriterInterface* file_writer) override;
+ size_t Alignment() override;
+ bool WriteObject(FileWriterInterface* file_writer) override;
// MinidumpContextWriter:
- virtual size_t ContextSize() const override;
+ size_t ContextSize() const override;
private:
MinidumpContextAMD64 context_;
« no previous file with comments | « no previous file | minidump/minidump_exception_writer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698