Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: minidump/minidump_memory_writer_test.cc

Issue 654933002: Use exactly one of final, override, and virtual (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: git grep -E '^ {3,}.*override[ Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « minidump/minidump_memory_writer.h ('k') | minidump/minidump_memory_writer_test_util.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: minidump/minidump_memory_writer_test.cc
diff --git a/minidump/minidump_memory_writer_test.cc b/minidump/minidump_memory_writer_test.cc
index b13f71275d240f931c776bcbe2a3c978c39abc32..a59edcd3b10e5d15fd888c2d3e2a1b117bfe83a6 100644
--- a/minidump/minidump_memory_writer_test.cc
+++ b/minidump/minidump_memory_writer_test.cc
@@ -200,24 +200,24 @@ class TestMemoryStream final : public internal::MinidumpStreamWriter {
TestMinidumpMemoryWriter* memory() { return &memory_; }
// MinidumpStreamWriter:
- virtual MinidumpStreamType StreamType() const override {
+ MinidumpStreamType StreamType() const override {
return kBogusStreamType;
}
protected:
// MinidumpWritable:
- virtual size_t SizeOfObject() override {
+ size_t SizeOfObject() override {
EXPECT_GE(state(), kStateFrozen);
return 0;
}
- virtual std::vector<MinidumpWritable*> Children() override {
+ std::vector<MinidumpWritable*> Children() override {
EXPECT_GE(state(), kStateFrozen);
std::vector<MinidumpWritable*> children(1, memory());
return children;
}
- virtual bool WriteObject(FileWriterInterface* file_writer) override {
+ bool WriteObject(FileWriterInterface* file_writer) override {
EXPECT_EQ(kStateWritable, state());
return true;
}
« no previous file with comments | « minidump/minidump_memory_writer.h ('k') | minidump/minidump_memory_writer_test_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698