Add counting of some GL calls

Add counting of some GL calls

I would like this facility for tracking FBO switch improvements.

Committed: https://skia.googlesource.com/skia/+/754f4e98d94d7c9ed76cd128cf983f9323a1885b

[robertphillips, 2014-09-17 14:34:31]

robertphillips@google.com changed reviewers:
+ bsalomon@google.com

[bsalomon, 2014-09-17 14:45:44]

Gathering stats about the # of times Ganesh does something has come up a few
times (fbo binds, shader compiles, draw cnt, ...). Could we make this a stats
struct even if it only has one member for now?

[robertphillips, 2014-09-17 18:28:43]

PTAL

[bsalomon, 2014-09-17 18:50:16]

https://codereview.chromium.org/553583008/diff/80001/src/gpu/GrGpu.h
File src/gpu/GrGpu.h (right):

https://codereview.chromium.org/553583008/diff/80001/src/gpu/GrGpu.h#newcode344
src/gpu/GrGpu.h:344: virtual const GrContext::GPUStats& gpuStats() const = 0;
Why does this have to be virtual?

https://codereview.chromium.org/553583008/diff/80001/src/gpu/gl/GrGpuGL.h
File src/gpu/gl/GrGpuGL.h (right):

https://codereview.chromium.org/553583008/diff/80001/src/gpu/gl/GrGpuGL.h#new...
src/gpu/gl/GrGpuGL.h:99: GrContext::GPUStats fGPUStats;
Instead of making this public and passing GrGpuGL around, could we make GrGpuGL
pass a GpuStats* to functions that have to update it?

[robertphillips, 2014-09-18 13:21:44]

PTAL. This patch attempts to balance bit-rot-prevention & needless extra work.

[robertphillips, 2014-09-18 18:55:26]

Thoughts on this?

[bsalomon, 2014-09-18 19:18:50]

lgtm

[robertphillips, 2014-09-18 19:31:34]

The CQ bit was checked by robertphillips@google.com

[commit-bot: I haz the power, 2014-09-18 19:32:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/553583008/120001

[commit-bot: I haz the power, 2014-09-18 19:32:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-18 19:32:19]

Failed to apply patch for src/gpu/gl/builders/GrGLVertexShaderBuilder.cpp:
While running git apply --index -p1;
  error: patch failed: src/gpu/gl/builders/GrGLVertexShaderBuilder.cpp:122
  error: src/gpu/gl/builders/GrGLVertexShaderBuilder.cpp: patch does not apply

Patch:       src/gpu/gl/builders/GrGLVertexShaderBuilder.cpp
Index: src/gpu/gl/builders/GrGLVertexShaderBuilder.cpp
diff --git a/src/gpu/gl/builders/GrGLVertexShaderBuilder.cpp
b/src/gpu/gl/builders/GrGLVertexShaderBuilder.cpp
index
7445676f5884c5bf4a01110b1579f0e761182a94..c75b392bccd0fd7ca167637d165055d84b467b4c
100644
--- a/src/gpu/gl/builders/GrGLVertexShaderBuilder.cpp
+++ b/src/gpu/gl/builders/GrGLVertexShaderBuilder.cpp
@@ -122,7 +122,8 @@ bool
GrGLVertexShaderBuilder::compileAndAttachShaders(GrGLuint programId,
     vertShaderSrc.append(fCode);
     vertShaderSrc.append("}\n");
     GrGLuint vertShaderId = GrGLCompileAndAttachShader(glCtx, programId,
-            GR_GL_VERTEX_SHADER, vertShaderSrc);
+                                                       GR_GL_VERTEX_SHADER,
vertShaderSrc,
+                                                       gpu->gpuStats());
     if (!vertShaderId) {
         return false;
     }

[robertphillips, 2014-09-18 19:57:27]

The CQ bit was checked by robertphillips@google.com

[commit-bot: I haz the power, 2014-09-18 19:58:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/553583008/140001

[commit-bot: I haz the power, 2014-09-18 20:52:16]

Committed patchset #8 (id:140001) as 754f4e98d94d7c9ed76cd128cf983f9323a1885b