Issue 404993004: [Android] Switch to DeviceUtils versions of GetMemoryUsageForPid and __str__.

Issue 404993004: [Android] Switch to DeviceUtils versions of GetMemoryUsageForPid and str. (Closed)

Created:
6 years, 5 months ago by jbudorick

Modified:
6 years, 5 months ago

Reviewers:
craigdh, tonyg, frankf

CC:
chromium-reviews, yfriedman+watch_chromium.org, timurrrr+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, telemetry+watch_chromium.org, glider+watch_chromium.org, bruening+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[Android] Switch to DeviceUtils versions of GetMemoryUsageForPid and __str__. BUG=267773 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285097

Patch Set 1 #

Total comments: 4

Patch Set 2 : address comments from tonyg + rebase #

Patch Set 3 : address comment from frankf #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+129 lines, -23 lines)			Patch
M	build/android/pylib/device/device_utils.py	View	1 2	32 chunks	+64 lines, -0 lines	0 comments	Download
M	build/android/pylib/device/device_utils_test.py	View		1 chunk	+42 lines, -0 lines	0 comments	Download
M	build/android/pylib/forwarder.py	View		4 chunks	+4 lines, -4 lines	0 comments	Download
M	build/android/pylib/gtest/test_package_exe.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	build/android/pylib/gtest/test_runner.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	build/android/pylib/host_driven/test_runner.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	build/android/pylib/instrumentation/test_runner.py	View		2 chunks	+2 lines, -3 lines	0 comments	Download
M	build/android/pylib/perf/thermal_throttle.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	build/android/pylib/screenshot.py	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	build/android/pylib/valgrind_tools.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	build/android/tombstones.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/memory_inspector/memory_inspector/backends/android/android_backend.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/profile_chrome/perf_controller.py	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	tools/profile_chrome/systrace_controller.py	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	tools/telemetry/telemetry/core/forwarders/android_forwarder.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/telemetry/telemetry/core/platform/android_platform_backend.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

tonyg

lgtm https://codereview.chromium.org/404993004/diff/1/build/android/pylib/device/device_utils.py File build/android/pylib/device/device_utils.py (right): https://codereview.chromium.org/404993004/diff/1/build/android/pylib/device/device_utils.py#newcode736 build/android/pylib/device/device_utils.py:736: Returns: You should keep it this way in ...

6 years, 5 months ago (2014-07-21 16:02:09 UTC) #2

frankf

lgtm https://codereview.chromium.org/404993004/diff/1/build/android/pylib/device/device_utils.py File build/android/pylib/device/device_utils.py (right): https://codereview.chromium.org/404993004/diff/1/build/android/pylib/device/device_utils.py#newcode733 build/android/pylib/device/device_utils.py:733: pid: An integer containing the PID to get ...

6 years, 5 months ago (2014-07-23 16:39:44 UTC) #3

jbudorick

https://codereview.chromium.org/404993004/diff/1/build/android/pylib/device/device_utils.py File build/android/pylib/device/device_utils.py (right): https://codereview.chromium.org/404993004/diff/1/build/android/pylib/device/device_utils.py#newcode733 build/android/pylib/device/device_utils.py:733: pid: An integer containing the PID to get the ...

6 years, 5 months ago (2014-07-23 18:09:44 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbudorick@chromium.org/404993004/40001

6 years, 5 months ago (2014-07-23 18:11:45 UTC) #6

Message was sent while issue was closed.

Change committed as 285097

Expand Messages | Collapse Messages