build/android/pylib/screenshot.py - Issue 404993004: [Android] Switch to DeviceUtils versions of GetMemoryUsageForPid and __str__.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/screenshot.py

Issue 404993004: [Android] Switch to DeviceUtils versions of GetMemoryUsageForPid and __str__. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comment from frankf Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/pylib/screenshot.py

diff --git a/build/android/pylib/screenshot.py b/build/android/pylib/screenshot.py

index d69bb9a7c6d8943874d7ef151bc1734919cb564b..e21d7560b6e5854193362701e91d7935073fca60 100644

--- a/build/android/pylib/screenshot.py

+++ b/build/android/pylib/screenshot.py

@@ -38,8 +38,8 @@ class VideoRecorder(object):

self._is_started = False

self._args = ['adb']

- if self._device.old_interface.GetDevice():

- self._args += ['-s', self._device.old_interface.GetDevice()]

+ if str(self._device):

+ self._args += ['-s', str(self._device)]

self._args += ['shell', 'screenrecord', '--verbose']

self._args += ['--bit-rate', str(megabits_per_second * 1000 * 1000)]

if size:

« no previous file with comments | « build/android/pylib/perf/thermal_throttle.py ('k') | build/android/pylib/valgrind_tools.py » ('j') | no next file with comments »