tools/telemetry/telemetry/core/platform/android_platform_backend.py - Issue 404993004: [Android] Switch to DeviceUtils versions of GetMemoryUsageForPid and __str__.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/platform/android_platform_backend.py

Issue 404993004: [Android] Switch to DeviceUtils versions of GetMemoryUsageForPid and __str__. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comment from frankf Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/core/platform/android_platform_backend.py

diff --git a/tools/telemetry/telemetry/core/platform/android_platform_backend.py b/tools/telemetry/telemetry/core/platform/android_platform_backend.py

index 0537b4287a51b252b6ee6659bb3815803bcc1f7a..da73e408b6bfb3db03a4b2e86d75128e757239bd 100644

--- a/tools/telemetry/telemetry/core/platform/android_platform_backend.py

+++ b/tools/telemetry/telemetry/core/platform/android_platform_backend.py

@@ -137,7 +137,7 @@ class AndroidPlatformBackend(

raise Exception('Error while purging ashmem: ' + '\n'.join(output))

def GetMemoryStats(self, pid):

- memory_usage = self._device.old_interface.GetMemoryUsageForPid(pid)

+ memory_usage = self._device.GetMemoryUsageForPid(pid)

return {'ProportionalSetSize': memory_usage['Pss'] * 1024,

'SharedDirty': memory_usage['Shared_Dirty'] * 1024,

'PrivateDirty': memory_usage['Private_Dirty'] * 1024,

« no previous file with comments | « tools/telemetry/telemetry/core/forwarders/android_forwarder.py ('k') | no next file » | no next file with comments »