Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(712)

Side by Side Diff: build/android/pylib/valgrind_tools.py

Issue 404993004: [Android] Switch to DeviceUtils versions of GetMemoryUsageForPid and __str__. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comment from frankf Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/android/pylib/screenshot.py ('k') | build/android/tombstones.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """ 5 """
6 Classes in this file define additional actions that need to be taken to run a 6 Classes in this file define additional actions that need to be taken to run a
7 test under some kind of runtime error detection tool. 7 test under some kind of runtime error detection tool.
8 8
9 The interface is intended to be used as follows. 9 The interface is intended to be used as follows.
10 10
(...skipping 99 matching lines...) Expand 10 before | Expand all | Expand 10 after
110 'third_party/llvm-build/Release+Asserts/', 110 'third_party/llvm-build/Release+Asserts/',
111 'lib/clang/*/lib/linux/', 111 'lib/clang/*/lib/linux/',
112 'libclang_rt.asan-arm-android.so')) 112 'libclang_rt.asan-arm-android.so'))
113 assert len(libs) == 1 113 assert len(libs) == 1
114 self._lib = libs[0] 114 self._lib = libs[0]
115 115
116 def CopyFiles(self): 116 def CopyFiles(self):
117 """Copies ASan tools to the device.""" 117 """Copies ASan tools to the device."""
118 subprocess.call([os.path.join(DIR_SOURCE_ROOT, 118 subprocess.call([os.path.join(DIR_SOURCE_ROOT,
119 'tools/android/asan/asan_device_setup.sh'), 119 'tools/android/asan/asan_device_setup.sh'),
120 '--device', self._device.old_interface.GetDevice(), 120 '--device', str(self._device),
121 '--lib', self._lib, 121 '--lib', self._lib,
122 '--extra-options', AddressSanitizerTool.EXTRA_OPTIONS]) 122 '--extra-options', AddressSanitizerTool.EXTRA_OPTIONS])
123 self._device.WaitUntilFullyBooted() 123 self._device.WaitUntilFullyBooted()
124 124
125 def GetTestWrapper(self): 125 def GetTestWrapper(self):
126 return AddressSanitizerTool.WRAPPER_NAME 126 return AddressSanitizerTool.WRAPPER_NAME
127 127
128 def GetUtilWrapper(self): 128 def GetUtilWrapper(self):
129 """Returns the wrapper for utilities, such as forwarder. 129 """Returns the wrapper for utilities, such as forwarder.
130 130
(...skipping 138 matching lines...) Expand 10 before | Expand all | Expand 10 after
269 if not tool_name: 269 if not tool_name:
270 return BaseTool() 270 return BaseTool()
271 271
272 ctor = TOOL_REGISTRY.get(tool_name) 272 ctor = TOOL_REGISTRY.get(tool_name)
273 if ctor: 273 if ctor:
274 return ctor(device) 274 return ctor(device)
275 else: 275 else:
276 print 'Unknown tool %s, available tools: %s' % ( 276 print 'Unknown tool %s, available tools: %s' % (
277 tool_name, ', '.join(sorted(TOOL_REGISTRY.keys()))) 277 tool_name, ', '.join(sorted(TOOL_REGISTRY.keys())))
278 sys.exit(1) 278 sys.exit(1)
OLDNEW
« no previous file with comments | « build/android/pylib/screenshot.py ('k') | build/android/tombstones.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698