build/android/pylib/gtest/test_runner.py - Issue 404993004: [Android] Switch to DeviceUtils versions of GetMemoryUsageForPid and __str__.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/gtest/test_runner.py

Issue 404993004: [Android] Switch to DeviceUtils versions of GetMemoryUsageForPid and __str__. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comment from frankf Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/pylib/gtest/test_runner.py

diff --git a/build/android/pylib/gtest/test_runner.py b/build/android/pylib/gtest/test_runner.py

index c9a60449ccfac1e432d49dda781f5439e216b33a..faffe8fd1e38cda3322e780116fd5efa79b8b8c4 100644

--- a/build/android/pylib/gtest/test_runner.py

+++ b/build/android/pylib/gtest/test_runner.py

@@ -131,7 +131,7 @@ class TestRunner(base_test_runner.BaseTestRunner):

# crashed without outputting the CRASHED marker (crbug.com/175538).

if not self.device.IsOnline():

raise device_errors.DeviceUnreachableError(

- 'Device %s went offline.' % self.device.old_interface.GetDevice())

+ 'Device %s went offline.' % str(self.device))

if full_test_name:

results.AddResult(base_test_result.BaseTestResult(

full_test_name, base_test_result.ResultType.CRASH,

« no previous file with comments | « build/android/pylib/gtest/test_package_exe.py ('k') | build/android/pylib/host_driven/test_runner.py » ('j') | no next file with comments »