tools/memory_inspector/memory_inspector/backends/android/android_backend.py - Issue 404993004: [Android] Switch to DeviceUtils versions of GetMemoryUsageForPid and __str__.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/memory_inspector/memory_inspector/backends/android/android_backend.py

Issue 404993004: [Android] Switch to DeviceUtils versions of GetMemoryUsageForPid and __str__. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comment from frankf Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/memory_inspector/memory_inspector/backends/android/android_backend.py

diff --git a/tools/memory_inspector/memory_inspector/backends/android/android_backend.py b/tools/memory_inspector/memory_inspector/backends/android/android_backend.py

index bf10d5d969c54fa48dbf010425790430153aa24c..f38c2de21f7ebbfcc0fc97f06ab7917c1a498ff1 100644

--- a/tools/memory_inspector/memory_inspector/backends/android/android_backend.py

+++ b/tools/memory_inspector/memory_inspector/backends/android/android_backend.py

@@ -165,7 +165,7 @@ class AndroidDevice(backends.Device):

backend=backend,

settings=backends.Settings(AndroidDevice._SETTINGS_KEYS))

self.underlying_device = underlying_device

- self._id = underlying_device.old_interface.GetDevice()

+ self._id = str(underlying_device)

self._name = underlying_device.GetProp('ro.product.model')

self._sys_stats = None

self._last_device_stats = None

« no previous file with comments | « build/android/tombstones.py ('k') | tools/profile_chrome/perf_controller.py » ('j') | no next file with comments »