build/android/pylib/perf/thermal_throttle.py - Issue 404993004: [Android] Switch to DeviceUtils versions of GetMemoryUsageForPid and __str__.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/perf/thermal_throttle.py

Issue 404993004: [Android] Switch to DeviceUtils versions of GetMemoryUsageForPid and __str__. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comment from frankf Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/pylib/perf/thermal_throttle.py

diff --git a/build/android/pylib/perf/thermal_throttle.py b/build/android/pylib/perf/thermal_throttle.py

index a125e72fbd78a2fb1f77397bf57a0ff9db86f6c5..24e1ff4c0048c88e8f72f6d4ca58a07f0e1c2e2c 100644

--- a/build/android/pylib/perf/thermal_throttle.py

+++ b/build/android/pylib/perf/thermal_throttle.py

@@ -99,7 +99,7 @@ class ThermalThrottle(object):

if not self._detector:

return False

has_been_throttled = False

- serial_number = self._device.old_interface.GetDevice()

+ serial_number = str(self._device)

log = self._device.RunShellCommand('dmesg -c')

degree_symbol = unichr(0x00B0)

for line in log:

« no previous file with comments | « build/android/pylib/instrumentation/test_runner.py ('k') | build/android/pylib/screenshot.py » ('j') | no next file with comments »