build/android/pylib/host_driven/test_runner.py - Issue 404993004: [Android] Switch to DeviceUtils versions of GetMemoryUsageForPid and __str__.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/host_driven/test_runner.py

Issue 404993004: [Android] Switch to DeviceUtils versions of GetMemoryUsageForPid and __str__. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comment from frankf Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/pylib/host_driven/test_runner.py

diff --git a/build/android/pylib/host_driven/test_runner.py b/build/android/pylib/host_driven/test_runner.py

index 7072763cdcd90495bd9d3f053ab7a1a0169e0a87..b61fa40ea5d93257cea0e354612087ff9fb9661c 100644

--- a/build/android/pylib/host_driven/test_runner.py

+++ b/build/android/pylib/host_driven/test_runner.py

@@ -85,7 +85,7 @@ class HostDrivenTestRunner(base_test_runner.BaseTestRunner):

exception_raised = False

try:

- test.SetUp(self.device.old_interface.GetDevice(), self.shard_index,

+ test.SetUp(str(self.device), self.shard_index,

self._push_deps, self._cleanup_test_files)

except Exception:

logging.exception(

« no previous file with comments | « build/android/pylib/gtest/test_runner.py ('k') | build/android/pylib/instrumentation/test_runner.py » ('j') | no next file with comments »