build/android/pylib/valgrind_tools.py - Issue 404993004: [Android] Switch to DeviceUtils versions of GetMemoryUsageForPid and __str__.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/valgrind_tools.py

Issue 404993004: [Android] Switch to DeviceUtils versions of GetMemoryUsageForPid and __str__. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comment from frankf Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/pylib/valgrind_tools.py

diff --git a/build/android/pylib/valgrind_tools.py b/build/android/pylib/valgrind_tools.py

index f11ab03c68390fadfed1510ea6757548a8e8e0c4..69f351a674c436248d5007e1246f99f27942c79f 100644

--- a/build/android/pylib/valgrind_tools.py

+++ b/build/android/pylib/valgrind_tools.py

@@ -117,7 +117,7 @@ class AddressSanitizerTool(BaseTool):

"""Copies ASan tools to the device."""

subprocess.call([os.path.join(DIR_SOURCE_ROOT,

'tools/android/asan/asan_device_setup.sh'),

- '--device', self._device.old_interface.GetDevice(),

+ '--device', str(self._device),

'--lib', self._lib,

'--extra-options', AddressSanitizerTool.EXTRA_OPTIONS])

self._device.WaitUntilFullyBooted()

« no previous file with comments | « build/android/pylib/screenshot.py ('k') | build/android/tombstones.py » ('j') | no next file with comments »