build/android/pylib/gtest/test_package_exe.py - Issue 404993004: [Android] Switch to DeviceUtils versions of GetMemoryUsageForPid and __str__.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/gtest/test_package_exe.py

Issue 404993004: [Android] Switch to DeviceUtils versions of GetMemoryUsageForPid and __str__. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comment from frankf Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/pylib/gtest/test_package_exe.py

diff --git a/build/android/pylib/gtest/test_package_exe.py b/build/android/pylib/gtest/test_package_exe.py

index 9714c420812261497c358f49145d4523e81dd6f3..5f82aad7b550af76bf23f753b71578251d5df9b1 100644

--- a/build/android/pylib/gtest/test_package_exe.py

+++ b/build/android/pylib/gtest/test_package_exe.py

@@ -123,7 +123,7 @@ class TestPackageExecutable(TestPackage):

#override

def SpawnTestProcess(self, device):

- args = ['adb', '-s', device.old_interface.GetDevice(), 'shell', 'sh',

+ args = ['adb', '-s', str(device), 'shell', 'sh',

constants.TEST_EXECUTABLE_DIR + '/chrome_test_runner.sh']

logging.info(args)

return pexpect.spawn(args[0], args[1:], logfile=sys.stdout)

« no previous file with comments | « build/android/pylib/forwarder.py ('k') | build/android/pylib/gtest/test_runner.py » ('j') | no next file with comments »