Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Side by Side Diff: build/android/pylib/screenshot.py

Issue 404993004: [Android] Switch to DeviceUtils versions of GetMemoryUsageForPid and __str__. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comment from frankf Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/android/pylib/perf/thermal_throttle.py ('k') | build/android/pylib/valgrind_tools.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import os 5 import os
6 import signal 6 import signal
7 import tempfile 7 import tempfile
8 8
9 from pylib import cmd_helper 9 from pylib import cmd_helper
10 10
(...skipping 20 matching lines...) Expand all
31 if isinstance(device, pylib.android_commands.AndroidCommands): 31 if isinstance(device, pylib.android_commands.AndroidCommands):
32 device = pylib.device.device_utils.DeviceUtils(device) 32 device = pylib.device.device_utils.DeviceUtils(device)
33 self._device = device 33 self._device = device
34 self._device_file = ( 34 self._device_file = (
35 '%s/screen-recording.mp4' % device.GetExternalStoragePath()) 35 '%s/screen-recording.mp4' % device.GetExternalStoragePath())
36 self._recorder = None 36 self._recorder = None
37 self._recorder_stdout = None 37 self._recorder_stdout = None
38 self._is_started = False 38 self._is_started = False
39 39
40 self._args = ['adb'] 40 self._args = ['adb']
41 if self._device.old_interface.GetDevice(): 41 if str(self._device):
42 self._args += ['-s', self._device.old_interface.GetDevice()] 42 self._args += ['-s', str(self._device)]
43 self._args += ['shell', 'screenrecord', '--verbose'] 43 self._args += ['shell', 'screenrecord', '--verbose']
44 self._args += ['--bit-rate', str(megabits_per_second * 1000 * 1000)] 44 self._args += ['--bit-rate', str(megabits_per_second * 1000 * 1000)]
45 if size: 45 if size:
46 self._args += ['--size', '%dx%d' % size] 46 self._args += ['--size', '%dx%d' % size]
47 if rotate: 47 if rotate:
48 self._args += ['--rotate'] 48 self._args += ['--rotate']
49 self._args += [self._device_file] 49 self._args += [self._device_file]
50 50
51 def Start(self): 51 def Start(self):
52 """Start recording video.""" 52 """Start recording video."""
(...skipping 29 matching lines...) Expand all
82 Returns: 82 Returns:
83 Output video file name on the host. 83 Output video file name on the host.
84 """ 84 """
85 host_file_name = host_file or ('screen-recording-%s.mp4' % 85 host_file_name = host_file or ('screen-recording-%s.mp4' %
86 self._device.old_interface.GetTimestamp()) 86 self._device.old_interface.GetTimestamp())
87 host_file_name = os.path.abspath(host_file_name) 87 host_file_name = os.path.abspath(host_file_name)
88 self._device.old_interface.EnsureHostDirectory(host_file_name) 88 self._device.old_interface.EnsureHostDirectory(host_file_name)
89 self._device.PullFile(self._device_file, host_file_name) 89 self._device.PullFile(self._device_file, host_file_name)
90 self._device.RunShellCommand('rm -f "%s"' % self._device_file) 90 self._device.RunShellCommand('rm -f "%s"' % self._device_file)
91 return host_file_name 91 return host_file_name
OLDNEW
« no previous file with comments | « build/android/pylib/perf/thermal_throttle.py ('k') | build/android/pylib/valgrind_tools.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698