Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 385263004: Get rid of some uses of CreateIntegerValue (Closed)

Created:
6 years, 5 months ago by Evan Stade
Modified:
6 years, 5 months ago
Reviewers:
Lei Zhang, Nico
CC:
chromium-reviews, asanka, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, nkostylev+watch_chromium.org, benjhayden+dwatch_chromium.org, jam, yoshiki+watch_chromium.org, dbeam+watch-options_chromium.org, rginda+watch_chromium.org, stuartmorgan+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, markusheintz_, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Get rid of some uses of CreateIntegerValue BUG=160586 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284600

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : rebase #

Patch Set 4 : resolve ambiguity #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+255 lines, -248 lines) Patch
M chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/users/avatar/user_image_manager_browsertest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/proxy_cros_settings_parser.cc View 1 2 3 4 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/system/automatic_reboot_manager_unittest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/content_settings_default_provider.cc View 1 2 3 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/content_settings/content_settings_default_provider_unittest.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/content_settings/content_settings_internal_extension_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/content_settings_origin_identifier_value_map_unittest.cc View 5 chunks +17 lines, -19 lines 0 comments Download
M chrome/browser/content_settings/content_settings_policy_provider.cc View 1 2 2 chunks +11 lines, -13 lines 0 comments Download
M chrome/browser/content_settings/content_settings_policy_provider_unittest.cc View 1 2 3 4 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/content_settings/content_settings_pref_provider.cc View 1 2 3 4 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/content_settings/content_settings_pref_provider_unittest.cc View 1 2 3 4 8 chunks +12 lines, -14 lines 0 comments Download
M chrome/browser/content_settings/content_settings_provider_unittest.cc View 4 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/content_settings/content_settings_rule_unittest.cc View 1 2 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/content_settings/host_content_settings_map.cc View 1 2 3 4 4 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/content_settings/host_content_settings_map_unittest.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/download/download_query_unittest.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/guest_view/guest_view_internal_api.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/error_console/error_console.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/guest_view/web_view/web_view_guest.cc View 1 2 1 chunk +3 lines, -7 lines 0 comments Download
M chrome/browser/net/proxy_policy_handler_unittest.cc View 8 chunks +37 lines, -23 lines 0 comments Download
M chrome/browser/plugins/plugin_info_message_filter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/cloud/cloud_policy_browsertest.cc View 1 2 3 4 1 chunk +10 lines, -5 lines 0 comments Download
M chrome/browser/policy/javascript_policy_handler.cc View 1 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/policy/javascript_policy_handler_unittest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/policy_browsertest.cc View 1 2 3 4 15 chunks +55 lines, -35 lines 0 comments Download
M chrome/browser/prefs/chrome_pref_service_unittest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/command_line_pref_store.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/prefs/incognito_mode_prefs_unittest.cc View 2 chunks +4 lines, -7 lines 0 comments Download
M chrome/browser/prefs/pref_hash_calculator_unittest.cc View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/prefs/pref_hash_filter_unittest.cc View 1 2 3 4 4 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/prefs/pref_model_associator_unittest.cc View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/profiles/incognito_mode_policy_handler.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/profiles/incognito_mode_policy_handler_unittest.cc View 1 2 3 4 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/speech/extension_api/tts_engine_extension_api.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/task_profiler/task_profiler_data_serializer.cc View 1 3 chunks +11 lines, -26 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_browsertest.cc View 1 2 3 4 1 chunk +6 lines, -5 lines 0 comments Download
M chrome/browser/ui/website_settings/website_settings.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc View 1 2 3 4 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/policy_ui_browsertest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/sync_internals_ui_unittest.cc View 1 2 3 4 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 25 (0 generated)
Evan Stade
the changes to tests are completely mechanical. Some of the changes to non test files ...
6 years, 5 months ago (2014-07-11 22:37:07 UTC) #1
Nico
lgtm
6 years, 5 months ago (2014-07-16 18:58:32 UTC) #2
Evan Stade
ping thestig
6 years, 5 months ago (2014-07-16 21:06:05 UTC) #3
Nico
On 2014/07/16 21:06:05, Evan Stade wrote: > ping thestig I lgtm'd this 2h ago.
6 years, 5 months ago (2014-07-16 21:07:07 UTC) #4
Evan Stade
On 2014/07/16 21:07:07, Nico (away) wrote: > On 2014/07/16 21:06:05, Evan Stade wrote: > > ...
6 years, 5 months ago (2014-07-16 21:17:10 UTC) #5
Evan Stade
The CQ bit was checked by estade@chromium.org
6 years, 5 months ago (2014-07-16 21:17:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/385263004/20001
6 years, 5 months ago (2014-07-16 21:18:27 UTC) #7
Evan Stade
The CQ bit was checked by estade@chromium.org
6 years, 5 months ago (2014-07-16 22:00:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/385263004/40001
6 years, 5 months ago (2014-07-16 22:04:07 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-17 03:20:48 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-17 03:35:43 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_clang_dbg/builds/30339) linux_chromium_chromeos_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_rel/builds/48470)
6 years, 5 months ago (2014-07-17 03:35:45 UTC) #12
Evan Stade
The CQ bit was checked by estade@chromium.org
6 years, 5 months ago (2014-07-17 16:11:58 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/385263004/60001
6 years, 5 months ago (2014-07-17 16:12:37 UTC) #14
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 5 months ago (2014-07-17 16:34:58 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-17 16:38:13 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/builds/171181) ios_rel_device on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds/160223) ios_rel_device_ninja ...
6 years, 5 months ago (2014-07-17 16:38:14 UTC) #17
Evan Stade
The CQ bit was checked by estade@chromium.org
6 years, 5 months ago (2014-07-21 17:56:33 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/385263004/70001
6 years, 5 months ago (2014-07-21 17:58:05 UTC) #19
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-21 19:51:20 UTC) #20
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-21 20:33:28 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/41209)
6 years, 5 months ago (2014-07-21 20:33:30 UTC) #22
Evan Stade
The CQ bit was checked by estade@chromium.org
6 years, 5 months ago (2014-07-22 00:50:37 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/385263004/70001
6 years, 5 months ago (2014-07-22 00:51:45 UTC) #24
commit-bot: I haz the power
6 years, 5 months ago (2014-07-22 02:36:05 UTC) #25
Message was sent while issue was closed.
Change committed as 284600

Powered by Google App Engine
This is Rietveld 408576698