Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7888)

Unified Diff: chrome/browser/speech/extension_api/tts_engine_extension_api.cc

Issue 385263004: Get rid of some uses of CreateIntegerValue (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/speech/extension_api/tts_engine_extension_api.cc
diff --git a/chrome/browser/speech/extension_api/tts_engine_extension_api.cc b/chrome/browser/speech/extension_api/tts_engine_extension_api.cc
index a46ce83a141a6df7a6989e4a35ba88700ced8052..8c1527cccd6c7edf5ffde3570b52d63614dec247 100644
--- a/chrome/browser/speech/extension_api/tts_engine_extension_api.cc
+++ b/chrome/browser/speech/extension_api/tts_engine_extension_api.cc
@@ -140,7 +140,7 @@ void TtsExtensionEngine::Speak(Utterance* utterance,
bool sends_end_event = voice.events.find(TTS_EVENT_END) != voice.events.end();
scoped_ptr<base::ListValue> args(new base::ListValue());
- args->Set(0, new base::StringValue(utterance->text()));
+ args->AppendString(utterance->text());
// Pass through most options to the speech engine, but remove some
// that are handled internally.
@@ -167,8 +167,8 @@ void TtsExtensionEngine::Speak(Utterance* utterance,
if (!options->HasKey(constants::kLangKey))
options->SetString(constants::kLangKey, voice.lang);
- args->Set(1, options.release());
- args->Set(2, base::Value::CreateIntegerValue(utterance->id()));
+ args->Append(options.release());
+ args->AppendInteger(utterance->id());
scoped_ptr<extensions::Event> event(new extensions::Event(
tts_engine_events::kOnSpeak, args.Pass()));

Powered by Google App Engine
This is Rietveld 408576698