Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5592)

Unified Diff: chrome/browser/download/download_query_unittest.cc

Issue 385263004: Get rid of some uses of CreateIntegerValue (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/download/download_query_unittest.cc
diff --git a/chrome/browser/download/download_query_unittest.cc b/chrome/browser/download/download_query_unittest.cc
index c8f5330b5f805af8c6fc5c59cb45c49d428bb024..232e4166666cf83dff2bb79c78cd503a18083846 100644
--- a/chrome/browser/download/download_query_unittest.cc
+++ b/chrome/browser/download/download_query_unittest.cc
@@ -106,7 +106,7 @@ template<> void DownloadQueryTest::AddFilter(
template<> void DownloadQueryTest::AddFilter(
DownloadQuery::FilterType name, int cpp_value) {
- scoped_ptr<base::Value> value(base::Value::CreateIntegerValue(cpp_value));
+ scoped_ptr<base::Value> value(new base::FundamentalValue(cpp_value));
CHECK(query_.AddFilter(name, *value.get()));
}
@@ -158,7 +158,7 @@ TEST_F(DownloadQueryTest, DownloadQueryTest_ZeroItems) {
}
TEST_F(DownloadQueryTest, DownloadQueryTest_InvalidFilter) {
- scoped_ptr<base::Value> value(base::Value::CreateIntegerValue(0));
+ scoped_ptr<base::Value> value(new base::FundamentalValue(0));
EXPECT_FALSE(query()->AddFilter(
static_cast<DownloadQuery::FilterType>(kint32max),
*value.get()));

Powered by Google App Engine
This is Rietveld 408576698