Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3441)

Unified Diff: chrome/browser/content_settings/content_settings_provider_unittest.cc

Issue 385263004: Get rid of some uses of CreateIntegerValue (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/content_settings/content_settings_provider_unittest.cc
diff --git a/chrome/browser/content_settings/content_settings_provider_unittest.cc b/chrome/browser/content_settings/content_settings_provider_unittest.cc
index efd82e59b6165075f8bff6efea4240933801b660..b5933baeaabeb3b9a687528a3ec2c5a07dd861c8 100644
--- a/chrome/browser/content_settings/content_settings_provider_unittest.cc
+++ b/chrome/browser/content_settings/content_settings_provider_unittest.cc
@@ -22,8 +22,7 @@ TEST(ContentSettingsProviderTest, Mock) {
pattern,
CONTENT_SETTINGS_TYPE_PLUGINS,
"java_plugin",
- base::Value::CreateIntegerValue(CONTENT_SETTING_BLOCK));
-
+ new base::FundamentalValue(CONTENT_SETTING_BLOCK));
EXPECT_EQ(CONTENT_SETTING_BLOCK,
GetContentSetting(&mock_provider, url, url,
@@ -65,7 +64,7 @@ TEST(ContentSettingsProviderTest, Mock) {
pattern,
CONTENT_SETTINGS_TYPE_PLUGINS,
"java_plugin",
- base::Value::CreateIntegerValue(CONTENT_SETTING_ALLOW));
+ new base::FundamentalValue(CONTENT_SETTING_ALLOW));
EXPECT_TRUE(owned);
EXPECT_EQ(CONTENT_SETTING_ALLOW,
GetContentSetting(&mock_provider, url, url,
@@ -74,7 +73,7 @@ TEST(ContentSettingsProviderTest, Mock) {
mock_provider.set_read_only(true);
scoped_ptr<base::Value> value(
- base::Value::CreateIntegerValue(CONTENT_SETTING_BLOCK));
+ new base::FundamentalValue(CONTENT_SETTING_BLOCK));
owned = mock_provider.SetWebsiteSetting(
pattern,
pattern,
@@ -95,7 +94,7 @@ TEST(ContentSettingsProviderTest, Mock) {
pattern,
CONTENT_SETTINGS_TYPE_PLUGINS,
"java_plugin",
- base::Value::CreateIntegerValue(CONTENT_SETTING_BLOCK));
+ new base::FundamentalValue(CONTENT_SETTING_BLOCK));
EXPECT_TRUE(owned);
EXPECT_EQ(CONTENT_SETTING_BLOCK,
GetContentSetting(&mock_provider, url, url,

Powered by Google App Engine
This is Rietveld 408576698