Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3496)

Unified Diff: chrome/browser/guest_view/web_view/web_view_guest.cc

Issue 385263004: Get rid of some uses of CreateIntegerValue (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/guest_view/web_view/web_view_guest.cc
diff --git a/chrome/browser/guest_view/web_view/web_view_guest.cc b/chrome/browser/guest_view/web_view/web_view_guest.cc
index e6852d29fce3b0aa4b24fd72942b20ca89263643..74e1496892f96402c90947bdc0b26d79147bc61e 100644
--- a/chrome/browser/guest_view/web_view/web_view_guest.cc
+++ b/chrome/browser/guest_view/web_view/web_view_guest.cc
@@ -1179,16 +1179,12 @@ void WebViewGuest::RequestNewWindowPermission(
std::string storage_partition_id = GetStoragePartitionIdFromSiteURL(site_url);
base::DictionaryValue request_info;
- request_info.Set(webview::kInitialHeight,
- base::Value::CreateIntegerValue(initial_bounds.height()));
- request_info.Set(webview::kInitialWidth,
- base::Value::CreateIntegerValue(initial_bounds.width()));
+ request_info.SetInteger(webview::kInitialHeight, initial_bounds.height());
+ request_info.SetInteger(webview::kInitialWidth, initial_bounds.width());
request_info.Set(webview::kTargetURL,
new base::StringValue(new_window_info.url.spec()));
request_info.Set(webview::kName, new base::StringValue(new_window_info.name));
- request_info.Set(webview::kWindowID,
- base::Value::CreateIntegerValue(
- guest->GetGuestInstanceID()));
+ request_info.SetInteger(webview::kWindowID, guest->GetGuestInstanceID());
// We pass in partition info so that window-s created through newwindow
// API can use it to set their partition attribute.
request_info.Set(webview::kStoragePartitionId,
« no previous file with comments | « chrome/browser/extensions/error_console/error_console.cc ('k') | chrome/browser/net/proxy_policy_handler_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698