chrome/browser/extensions/api/guest_view/guest_view_internal_api.cc - Issue 385263004: Get rid of some uses of CreateIntegerValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/guest_view/guest_view_internal_api.cc

Issue 385263004: Get rid of some uses of CreateIntegerValue (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/download/download_query_unittest.cc ('k') | chrome/browser/extensions/error_console/error_console.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/guest_view/guest_view_internal_api.cc

diff --git a/chrome/browser/extensions/api/guest_view/guest_view_internal_api.cc b/chrome/browser/extensions/api/guest_view/guest_view_internal_api.cc

index 98f693cf62c8a129b66e9c4ba3829a88dae905e3..2e74c0aa5a641a97d07e066f6db2f30cca3bb37c 100644

--- a/chrome/browser/extensions/api/guest_view/guest_view_internal_api.cc

+++ b/chrome/browser/extensions/api/guest_view/guest_view_internal_api.cc

@@ -47,7 +47,7 @@ void GuestViewInternalCreateGuestFunction::CreateGuestCallback(

GuestViewBase* guest = GuestViewBase::FromWebContents(guest_web_contents);

guest_instance_id = guest->GetGuestInstanceID();

}

- SetResult(base::Value::CreateIntegerValue(guest_instance_id));

+ SetResult(new base::FundamentalValue(guest_instance_id));

SendResponse(true);

}

« no previous file with comments | « chrome/browser/download/download_query_unittest.cc ('k') | chrome/browser/extensions/error_console/error_console.cc » ('j') | no next file with comments »