Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5460)

Unified Diff: chrome/browser/ui/webui/sync_internals_ui_unittest.cc

Issue 385263004: Get rid of some uses of CreateIntegerValue (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/policy_ui_browsertest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/sync_internals_ui_unittest.cc
diff --git a/chrome/browser/ui/webui/sync_internals_ui_unittest.cc b/chrome/browser/ui/webui/sync_internals_ui_unittest.cc
index 5abfa19196711c450c42348c796af03f698e3ea0..f3b0cf9bdcaae9ea3dbc4b7112b5917400ded3f9 100644
--- a/chrome/browser/ui/webui/sync_internals_ui_unittest.cc
+++ b/chrome/browser/ui/webui/sync_internals_ui_unittest.cc
@@ -122,7 +122,7 @@ TEST_F(SyncInternalsUITestWithService, HandleJsReply) {
ASCIIToUTF16("chrome.sync.testMessage.handleReply(5,true);")));
base::ListValue args;
- args.Append(base::Value::CreateIntegerValue(5));
+ args.Append(new base::FundamentalValue(5));
args.Append(new base::FundamentalValue(true));
sync_internals_ui_->HandleJsReply("testMessage", JsArgList(&args));
}
@@ -130,7 +130,7 @@ TEST_F(SyncInternalsUITestWithService, HandleJsReply) {
TEST_F(SyncInternalsUITestWithService, OnWebUISendBasic) {
const std::string& name = "testName";
base::ListValue args;
- args.Append(base::Value::CreateIntegerValue(10));
+ args.Append(new base::FundamentalValue(10));
EXPECT_CALL(mock_js_controller_,
ProcessJsMessage(name, HasArgsAsList(args), _));
@@ -188,7 +188,7 @@ TEST_F(SyncInternalsUITestWithoutService, HandleJsReply) {
ASCIIToUTF16("chrome.sync.testMessage.handleReply(5,true);")));
base::ListValue args;
- args.Append(base::Value::CreateIntegerValue(5));
+ args.Append(new base::FundamentalValue(5));
args.Append(new base::FundamentalValue(true));
sync_internals_ui_->HandleJsReply(
"testMessage", JsArgList(&args));
@@ -197,7 +197,7 @@ TEST_F(SyncInternalsUITestWithoutService, HandleJsReply) {
TEST_F(SyncInternalsUITestWithoutService, OnWebUISendBasic) {
const std::string& name = "testName";
base::ListValue args;
- args.Append(base::Value::CreateIntegerValue(5));
+ args.Append(new base::FundamentalValue(5));
// Should drop the message.
sync_internals_ui_->OverrideHandleWebUIMessage(GURL(), name, args);
« no previous file with comments | « chrome/browser/ui/webui/policy_ui_browsertest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698