Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Side by Side Diff: chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc

Issue 385263004: Get rid of some uses of CreateIntegerValue (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/chromeos/login/users/avatar/user_image_manager_browsertest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/extensions/file_manager/private_api_file_syste m.h" 5 #include "chrome/browser/chromeos/extensions/file_manager/private_api_file_syste m.h"
6 6
7 #include <sys/statvfs.h> 7 #include <sys/statvfs.h>
8 8
9 #include "base/posix/eintr_wrapper.h" 9 #include "base/posix/eintr_wrapper.h"
10 #include "base/strings/string_number_conversions.h" 10 #include "base/strings/string_number_conversions.h"
(...skipping 568 matching lines...) Expand 10 before | Expand all | Expand 10 after
579 source_url, 579 source_url,
580 destination_url), 580 destination_url),
581 base::Bind(&FileBrowserPrivateStartCopyFunction::RunAfterStartCopy, 581 base::Bind(&FileBrowserPrivateStartCopyFunction::RunAfterStartCopy,
582 this)); 582 this));
583 } 583 }
584 584
585 void FileBrowserPrivateStartCopyFunction::RunAfterStartCopy( 585 void FileBrowserPrivateStartCopyFunction::RunAfterStartCopy(
586 int operation_id) { 586 int operation_id) {
587 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); 587 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
588 588
589 SetResult(base::Value::CreateIntegerValue(operation_id)); 589 SetResult(new base::FundamentalValue(operation_id));
590 SendResponse(true); 590 SendResponse(true);
591 } 591 }
592 592
593 bool FileBrowserPrivateCancelCopyFunction::RunAsync() { 593 bool FileBrowserPrivateCancelCopyFunction::RunAsync() {
594 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); 594 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
595 595
596 using extensions::api::file_browser_private::CancelCopy::Params; 596 using extensions::api::file_browser_private::CancelCopy::Params;
597 const scoped_ptr<Params> params(Params::Create(*args_)); 597 const scoped_ptr<Params> params(Params::Create(*args_));
598 EXTENSION_FUNCTION_VALIDATE(params); 598 EXTENSION_FUNCTION_VALIDATE(params);
599 599
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
672 "/" + entry_definition_list->at(i).full_path.AsUTF8Unsafe(); 672 "/" + entry_definition_list->at(i).full_path.AsUTF8Unsafe();
673 entry->file_is_directory = entry_definition_list->at(i).is_directory; 673 entry->file_is_directory = entry_definition_list->at(i).is_directory;
674 entries.push_back(entry); 674 entries.push_back(entry);
675 } 675 }
676 676
677 results_ = extensions::api::file_browser_private_internal:: 677 results_ = extensions::api::file_browser_private_internal::
678 ResolveIsolatedEntries::Results::Create(entries); 678 ResolveIsolatedEntries::Results::Create(entries);
679 SendResponse(true); 679 SendResponse(true);
680 } 680 }
681 } // namespace extensions 681 } // namespace extensions
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/chromeos/login/users/avatar/user_image_manager_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698