chrome/browser/extensions/api/guest_view/guest_view_internal_api.cc - Issue 385263004: Get rid of some uses of CreateIntegerValue

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/extensions/api/guest_view/guest_view_internal_api.cc

Issue 385263004: Get rid of some uses of CreateIntegerValue (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/browser/download/download_query_unittest.cc ('k') | chrome/browser/extensions/error_console/error_console.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/extensions/api/guest_view/guest_view_internal_api.h"	5 #include "chrome/browser/extensions/api/guest_view/guest_view_internal_api.h"

6	6

7 #include "chrome/browser/guest_view/guest_view_base.h"	7 #include "chrome/browser/guest_view/guest_view_base.h"

8 #include "chrome/browser/guest_view/guest_view_manager.h"	8 #include "chrome/browser/guest_view/guest_view_manager.h"

9 #include "chrome/browser/profiles/profile.h"	9 #include "chrome/browser/profiles/profile.h"

10 #include "chrome/common/extensions/api/guest_view_internal.h"	10 #include "chrome/common/extensions/api/guest_view_internal.h"

(...skipping 29 matching lines...) Expand all Loading...
40 return true;	40 return true;

41 }	41 }

42	42

43 void GuestViewInternalCreateGuestFunction::CreateGuestCallback(	43 void GuestViewInternalCreateGuestFunction::CreateGuestCallback(

44 content::WebContents* guest_web_contents) {	44 content::WebContents* guest_web_contents) {

45 int guest_instance_id = 0;	45 int guest_instance_id = 0;

46 if (guest_web_contents) {	46 if (guest_web_contents) {

47 GuestViewBase* guest = GuestViewBase::FromWebContents(guest_web_contents);	47 GuestViewBase* guest = GuestViewBase::FromWebContents(guest_web_contents);

48 guest_instance_id = guest->GetGuestInstanceID();	48 guest_instance_id = guest->GetGuestInstanceID();

49 }	49 }

50 SetResult(base::Value::CreateIntegerValue(guest_instance_id));	50 SetResult(new base::FundamentalValue(guest_instance_id));

51 SendResponse(true);	51 SendResponse(true);

52 }	52 }

53	53

54 } // namespace extensions	54 } // namespace extensions

OLD	NEW