Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(670)

Unified Diff: chrome/browser/prefs/incognito_mode_prefs_unittest.cc

Issue 385263004: Get rid of some uses of CreateIntegerValue (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prefs/incognito_mode_prefs_unittest.cc
diff --git a/chrome/browser/prefs/incognito_mode_prefs_unittest.cc b/chrome/browser/prefs/incognito_mode_prefs_unittest.cc
index d2ba49c7631adf1448639683386d90cc33d8c1a6..fc343d549992a5925bf89346ead48b3b7b3d9b0f 100644
--- a/chrome/browser/prefs/incognito_mode_prefs_unittest.cc
+++ b/chrome/browser/prefs/incognito_mode_prefs_unittest.cc
@@ -38,20 +38,17 @@ TEST_F(IncognitoModePrefsTest, IntToAvailability) {
TEST_F(IncognitoModePrefsTest, GetAvailability) {
prefs_.SetUserPref(prefs::kIncognitoModeAvailability,
- base::Value::CreateIntegerValue(
- IncognitoModePrefs::ENABLED));
+ new base::FundamentalValue(IncognitoModePrefs::ENABLED));
EXPECT_EQ(IncognitoModePrefs::ENABLED,
IncognitoModePrefs::GetAvailability(&prefs_));
prefs_.SetUserPref(prefs::kIncognitoModeAvailability,
- base::Value::CreateIntegerValue(
- IncognitoModePrefs::DISABLED));
+ new base::FundamentalValue(IncognitoModePrefs::DISABLED));
EXPECT_EQ(IncognitoModePrefs::DISABLED,
IncognitoModePrefs::GetAvailability(&prefs_));
prefs_.SetUserPref(prefs::kIncognitoModeAvailability,
- base::Value::CreateIntegerValue(
- IncognitoModePrefs::FORCED));
+ new base::FundamentalValue(IncognitoModePrefs::FORCED));
EXPECT_EQ(IncognitoModePrefs::FORCED,
IncognitoModePrefs::GetAvailability(&prefs_));
}
@@ -61,7 +58,7 @@ typedef IncognitoModePrefsTest IncognitoModePrefsDeathTest;
#if GTEST_HAS_DEATH_TEST
TEST_F(IncognitoModePrefsDeathTest, GetAvailabilityBadValue) {
prefs_.SetUserPref(prefs::kIncognitoModeAvailability,
- base::Value::CreateIntegerValue(-1));
+ new base::FundamentalValue(-1));
#if defined(NDEBUG) && defined(DCHECK_ALWAYS_ON)
EXPECT_DEATH({
IncognitoModePrefs::Availability availability =
« no previous file with comments | « chrome/browser/prefs/command_line_pref_store.cc ('k') | chrome/browser/prefs/pref_hash_calculator_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698