chrome/browser/content_settings/content_settings_policy_provider_unittest.cc - Issue 385263004: Get rid of some uses of CreateIntegerValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/content_settings/content_settings_policy_provider_unittest.cc

Issue 385263004: Get rid of some uses of CreateIntegerValue (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/content_settings/content_settings_policy_provider.cc ('k') | chrome/browser/content_settings/content_settings_pref_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/content_settings/content_settings_policy_provider_unittest.cc

diff --git a/chrome/browser/content_settings/content_settings_policy_provider_unittest.cc b/chrome/browser/content_settings/content_settings_policy_provider_unittest.cc

index 852b395a564ee12904c72b813b8d83fc492083a7..b5b0e635768604ffe52eb0f570564925ed61f998 100644

--- a/chrome/browser/content_settings/content_settings_policy_provider_unittest.cc

+++ b/chrome/browser/content_settings/content_settings_policy_provider_unittest.cc

@@ -61,7 +61,7 @@ TEST_F(PolicyProviderTest, DefaultGeolocationContentSetting) {

// Change the managed value of the default geolocation setting

prefs->SetManagedPref(prefs::kManagedDefaultGeolocationSetting,

- base::Value::CreateIntegerValue(CONTENT_SETTING_BLOCK));

+ new base::FundamentalValue(CONTENT_SETTING_BLOCK));

rule_iterator.reset(

provider.GetRuleIterator(

@@ -85,7 +85,7 @@ TEST_F(PolicyProviderTest, ManagedDefaultContentSettings) {

PolicyProvider provider(prefs);

prefs->SetManagedPref(prefs::kManagedDefaultPluginsSetting,

- base::Value::CreateIntegerValue(CONTENT_SETTING_BLOCK));

+ new base::FundamentalValue(CONTENT_SETTING_BLOCK));

scoped_ptr<RuleIterator> rule_iterator(

provider.GetRuleIterator(

@@ -121,7 +121,7 @@ TEST_F(PolicyProviderTest, ObserveManagedSettingsChange) {

// Set the managed default-content-setting.

prefs->SetManagedPref(prefs::kManagedDefaultImagesSetting,

- base::Value::CreateIntegerValue(CONTENT_SETTING_BLOCK));

+ new base::FundamentalValue(CONTENT_SETTING_BLOCK));

::testing::Mock::VerifyAndClearExpectations(&mock_observer);

EXPECT_CALL(mock_observer,

OnContentSettingChanged(_,

@@ -187,7 +187,7 @@ TEST_F(PolicyProviderTest, GettingManagedContentSettings) {

// enforced via policies and not set by the user or extension. So a call to

// SetWebsiteSetting does nothing.

scoped_ptr<base::Value> value_block(

- base::Value::CreateIntegerValue(CONTENT_SETTING_BLOCK));

+ new base::FundamentalValue(CONTENT_SETTING_BLOCK));

bool owned = provider.SetWebsiteSetting(yt_url_pattern,

yt_url_pattern,

CONTENT_SETTINGS_TYPE_COOKIES,