Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(757)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 374923002: Goodbye GrEffectRef. (Closed)

Created:
6 years, 5 months ago by bsalomon
Modified:
6 years, 5 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@noref3
Visibility:
Public.

Description

Goodbye GrEffectRef. Also, reworked some var names and comments around SkShader::asNewEffect. Committed: https://skia.googlesource.com/skia/+/83d081ae1d731b5039e99823620f5e287542ee39

Patch Set 1 #

Patch Set 2 : comment adjustment #

Total comments: 10

Patch Set 3 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+594 lines, -597 lines) Patch
M gm/beziereffects.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M gm/convexpolyeffect.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M gm/rrects.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/texturedomaineffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/yuvtorgbeffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkColorShader.h View 1 chunk +2 lines, -2 lines 0 comments Download
M include/core/SkShader.h View 1 1 chunk +15 lines, -8 lines 0 comments Download
M include/gpu/GrContext.h View 1 chunk +6 lines, -6 lines 0 comments Download
M include/gpu/GrEffect.h View 1 chunk +0 lines, -2 lines 0 comments Download
M include/gpu/SkGr.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkBitmapProcShader.cpp View 3 chunks +9 lines, -8 lines 0 comments Download
M src/core/SkImageFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkPictureShader.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M src/core/SkShader.cpp View 2 chunks +8 lines, -8 lines 0 comments Download
M src/core/SkXfermode.cpp View 3 chunks +6 lines, -7 lines 0 comments Download
M src/effects/SkAlphaThresholdFilter.cpp View 2 chunks +8 lines, -8 lines 0 comments Download
M src/effects/SkArithmeticMode.cpp View 4 chunks +7 lines, -7 lines 0 comments Download
M src/effects/SkBlurMaskFilter.cpp View 7 chunks +13 lines, -15 lines 0 comments Download
M src/effects/SkColorFilters.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M src/effects/SkColorMatrixFilter.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M src/effects/SkDisplacementMapEffect.cpp View 2 chunks +9 lines, -9 lines 0 comments Download
M src/effects/SkGpuBlurUtils.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/SkLightingImageFilter.cpp View 8 chunks +27 lines, -23 lines 0 comments Download
M src/effects/SkLumaColorFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkMagnifierImageFilter.cpp View 1 2 4 chunks +14 lines, -13 lines 0 comments Download
M src/effects/SkMatrixConvolutionImageFilter.cpp View 3 chunks +14 lines, -14 lines 0 comments Download
M src/effects/SkMorphologyImageFilter.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M src/effects/SkPerlinNoiseShader.cpp View 8 chunks +20 lines, -20 lines 0 comments Download
M src/effects/SkTableColorFilter.cpp View 2 chunks +7 lines, -7 lines 0 comments Download
M src/effects/SkXfermodeImageFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkLinearGradient.h View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkLinearGradient.cpp View 6 chunks +17 lines, -17 lines 0 comments Download
M src/effects/gradients/SkRadialGradient.cpp View 6 chunks +17 lines, -17 lines 0 comments Download
M src/effects/gradients/SkSweepGradient.cpp View 6 chunks +12 lines, -14 lines 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient.h View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient_gpu.cpp View 16 chunks +66 lines, -66 lines 0 comments Download
M src/effects/gradients/SkTwoPointRadialGradient.cpp View 6 chunks +17 lines, -17 lines 0 comments Download
M src/gpu/GrAAConvexPathRenderer.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M src/gpu/GrAAHairLinePathRenderer.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/GrAARectRenderer.cpp View 6 chunks +12 lines, -12 lines 0 comments Download
M src/gpu/GrBitmapTextContext.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrClipMaskManager.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrContext.cpp View 4 chunks +8 lines, -8 lines 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 13 chunks +23 lines, -23 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/SkGr.cpp View 6 chunks +15 lines, -16 lines 0 comments Download
M src/gpu/effects/GrBezierEffect.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/effects/GrBezierEffect.cpp View 3 chunks +15 lines, -15 lines 0 comments Download
M src/gpu/effects/GrBicubicEffect.h View 3 chunks +7 lines, -7 lines 0 comments Download
M src/gpu/effects/GrBicubicEffect.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M src/gpu/effects/GrConfigConversionEffect.h View 1 chunk +4 lines, -4 lines 0 comments Download
M src/gpu/effects/GrConfigConversionEffect.cpp View 2 chunks +8 lines, -8 lines 0 comments Download
M src/gpu/effects/GrConvexPolyEffect.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/effects/GrConvexPolyEffect.cpp View 5 chunks +14 lines, -13 lines 0 comments Download
M src/gpu/effects/GrConvolutionEffect.h View 2 chunks +12 lines, -12 lines 0 comments Download
M src/gpu/effects/GrConvolutionEffect.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M src/gpu/effects/GrCustomCoordsTextureEffect.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrCustomCoordsTextureEffect.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M src/gpu/effects/GrDashingEffect.cpp View 1 2 7 chunks +18 lines, -20 lines 0 comments Download
M src/gpu/effects/GrDistanceFieldTextureEffect.h View 2 chunks +8 lines, -9 lines 0 comments Download
M src/gpu/effects/GrDistanceFieldTextureEffect.cpp View 2 chunks +8 lines, -8 lines 0 comments Download
M src/gpu/effects/GrDitherEffect.cpp View 3 chunks +6 lines, -8 lines 0 comments Download
M src/gpu/effects/GrOvalEffect.cpp View 1 2 7 chunks +16 lines, -18 lines 0 comments Download
M src/gpu/effects/GrRRectEffect.cpp View 8 chunks +17 lines, -17 lines 0 comments Download
M src/gpu/effects/GrSimpleTextureEffect.h View 1 chunk +11 lines, -11 lines 0 comments Download
M src/gpu/effects/GrSimpleTextureEffect.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M src/gpu/effects/GrTextureDomain.h View 1 chunk +6 lines, -6 lines 0 comments Download
M src/gpu/effects/GrTextureDomain.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M src/gpu/effects/GrYUVtoRGBEffect.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M tests/GLProgramsTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/GpuColorFilterTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
bsalomon
This is the last CL to remove GrEffectRef. This is mostly a replace of GrEffectRef ...
6 years, 5 months ago (2014-07-08 15:24:47 UTC) #1
robertphillips
lgtm + nits https://codereview.chromium.org/374923002/diff/20001/src/effects/SkMagnifierImageFilter.cpp File src/effects/SkMagnifierImageFilter.cpp (right): https://codereview.chromium.org/374923002/diff/20001/src/effects/SkMagnifierImageFilter.cpp#newcode254 src/effects/SkMagnifierImageFilter.cpp:254: #if SK_SUPPORT_GPU overlength ? https://codereview.chromium.org/374923002/diff/20001/src/gpu/SkGpuDevice.cpp File ...
6 years, 5 months ago (2014-07-08 15:42:27 UTC) #2
bsalomon
https://codereview.chromium.org/374923002/diff/20001/src/effects/SkMagnifierImageFilter.cpp File src/effects/SkMagnifierImageFilter.cpp (right): https://codereview.chromium.org/374923002/diff/20001/src/effects/SkMagnifierImageFilter.cpp#newcode254 src/effects/SkMagnifierImageFilter.cpp:254: #if SK_SUPPORT_GPU On 2014/07/08 15:42:27, robertphillips wrote: > overlength ...
6 years, 5 months ago (2014-07-08 16:30:51 UTC) #3
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 5 months ago (2014-07-08 16:30:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/374923002/40001
6 years, 5 months ago (2014-07-08 16:31:18 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-08 16:56:16 UTC) #6
Message was sent while issue was closed. 
Change committed as 83d081ae1d731b5039e99823620f5e287542ee39

Powered by Google App Engine
This is Rietveld 408576698