src/effects/SkGpuBlurUtils.cpp - Issue 374923002: Goodbye GrEffectRef.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkGpuBlurUtils.cpp

Issue 374923002: Goodbye GrEffectRef. (Closed) Base URL: https://skia.googlesource.com/skia.git@noref3

Patch Set: Address comments Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/SkGpuBlurUtils.cpp

diff --git a/src/effects/SkGpuBlurUtils.cpp b/src/effects/SkGpuBlurUtils.cpp

index 9da08e6f71f0f32d84d21aef5d027e4ffa7bdcb4..58881087553cb8a7e20f2bd15ef5b99b0cb0819d 100644

--- a/src/effects/SkGpuBlurUtils.cpp

+++ b/src/effects/SkGpuBlurUtils.cpp

@@ -54,7 +54,7 @@ static void convolve_gaussian_pass(GrContext* context,

float bounds[2]) {

GrPaint paint;

paint.reset();

- SkAutoTUnref<GrEffectRef> conv(GrConvolutionEffect::CreateGaussian(

+ SkAutoTUnref<GrEffect> conv(GrConvolutionEffect::CreateGaussian(

texture, direction, radius, sigma, useBounds, bounds));

paint.reset();

paint.addColorEffect(conv);

@@ -174,7 +174,7 @@ GrTexture* GaussianBlur(GrContext* context,

matrix.mapRect(&domain, rect);

domain.inset(i < scaleFactorX ? SK_ScalarHalf / srcTexture->width() : 0.0f,

i < scaleFactorY ? SK_ScalarHalf / srcTexture->height() : 0.0f);

- SkAutoTUnref<GrEffectRef> effect(GrTextureDomainEffect::Create(

+ SkAutoTUnref<GrEffect> effect(GrTextureDomainEffect::Create(

srcTexture,

matrix,

domain,

« no previous file with comments | « src/effects/SkDisplacementMapEffect.cpp ('k') | src/effects/SkLightingImageFilter.cpp » ('j') | no next file with comments »